ISSUE 608 : Support one way SSL in schema registry client. #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guruchai
approved these changes
Oct 18, 2019
|
|
||
| if (sslConfigurations.containsKey(SSL_TRUST_STORE_PATH)) { | ||
| sslConfigurator.trustStoreType(sslConfigurations.get("trustStoreType")) | ||
| .trustStoreFile(sslConfigurations.get("trustStorePath")) |
There was a problem hiding this comment.
nit: you can replace this with SSL_TRUST_STORE_PATH
| return Arrays.asList(SchemaRegistryTestProfileType.DEFAULT, SchemaRegistryTestProfileType.SSL); | ||
| return Arrays.asList(SchemaRegistryTestProfileType.DEFAULT, | ||
| SchemaRegistryTestProfileType.SSL, | ||
| SchemaRegistryTestProfileType.SSL_WITH_SERVER_AUTH); |
There was a problem hiding this comment.
nit: SSL_WITH_SERVER_AUTH sounds a bit confusing to me. Do you want to change to it to ONE_WAY_SSL?
There was a problem hiding this comment.
The profile I introduced requires server authentication but client doesn't and I wanted to add another profile where client requires authentication but server doesn't. If you think its ok to only have the former we can change it to ONE_WAY_SSL, if not I will add SSL_WITH_CLIENT_AUTH profile.
raju-saravanan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #608