ISSUE-598: Fix SR to run on Java 11 #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kamalcph
commented
Oct 1, 2019
kamalcph
commented
- Used G1GC instead of parallel GC.
- Included JAXB-API and it's runtime jars to run the JDK8 compiled build on JRE11.
|
This PR is built on top of #597 |
|
@kamalcph Can you rebase this PR with latest MASTER ? |
* Used G1GC instead of parallel GC. * Included JAXB-API and it's runtime jars to run the JDK8 compiled build on JRE11.
|
@raju-saravanan |
| # GC options | ||
| GC_LOG_FILE_NAME='registry-gc.log' | ||
| if [ -z "$REGISTRY_GC_LOG_OPTS" ]; then | ||
| JAVA_MAJOR_VERSION=$($JAVA -version 2>&1 | sed -E -n 's/.* version "([0-9]*).*$/\1/p') |
There was a problem hiding this comment.
nit : Shouldn't it be "([0-9]+) instead of "([0-9]*) ?
There was a problem hiding this comment.
Both of them works!
There was a problem hiding this comment.
@kamalcph It's a nit :)
| System.out.println("Failed to load " + jarFile + " into classpath."); | ||
| throw new Exception(e); | ||
| } | ||
| } | ||
|
|
||
| static class MyURLClassLoader extends URLClassLoader { |
There was a problem hiding this comment.
May be we can call this JarClassLoader or some other better name ?
There was a problem hiding this comment.
Renamed to JarClassLoader.
| String bootstrapDirPath, | ||
| String mysqlJarUrl, | ||
| Proxy proxy) throws Exception { | ||
| public static ClassLoader downloadMySQLJarIfNeeded(StorageProviderConfiguration storageProperties, |
There was a problem hiding this comment.
May be we can call this loadMySQLJarIfNeeded() ?
There was a problem hiding this comment.
Renamed to maybeLoadMySQLJar.
* Addressed the review comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.