[SPARK-LLAP-70]Implement against Apache Spark 2.2 #118
Conversation
|
@bikassaha @dongjoon-hyun you can review this later after I have done the testing. |
|
Thank you for pinging me, @merlingtang. Please let me know after the test pass. |
merlintang
changed the title
|
So, the test suite is not passed here for some reasons? |
|
Could you share the test result? Which is passed and failed? |
| + override def serviceName: String = "hiveserver2" | ||
| + | ||
| + override def obtainCredentials( | ||
| + hadoopConf: Configuration, |
| + } | ||
| + | ||
| + /** | ||
| + * Run some code as the real logged in user (which may differ from the current user, for |
| private val HIVE_SESSION_STATE_BUILDER_CLASS_NAME = | ||
| "org.apache.spark.sql.hive.HiveSessionStateBuilder" | ||
|
|
||
| + // HDP Llap SessionStateBuilder |
|
|
||
| + // HDP Llap SessionStateBuilder | ||
| + private val LLAP_SESSION_STATE_BUILDER_CLASS_NAME = | ||
| + "org.apache.spark.sql.hive.LlapSessionStateBuilder" |
|
|
||
| + | ||
| + /** | ||
| + * Return true if `spark.sql.hive.llap=true` and classes can be loaded. |
| /** | ||
| - * Run some code as the real logged in user (which may differ from the current user, for | ||
| - * example, when using proxying). | ||
| - */ |
There was a problem hiding this comment.
Could you fix all indentation issues? Especially, this is a wrong update.
There was a problem hiding this comment.
thanks, I will update all of them.
| - * Return true if `spark.sql.hive.llap=true` and classes can be loaded. | ||
| - * On class loading errors, it will fails. | ||
| - * Return false if `spark.sql.hive.llap=false`. | ||
| - */ |
There was a problem hiding this comment.
Uh... The patch file seems to be wrong.
|
I finished my first round. @merlintang . |
build.sbt
Outdated
| @@ -1,6 +1,6 @@ | |||
|
|
|||
| name := "spark-llap" | |||
| version := "1.1.1-2.1" | |||
| version := "1.1.1-2.2" | |||
There was a problem hiding this comment.
You need to change the versions in assembly together.
There was a problem hiding this comment.
Did you change assembly versions?
|
Hi, @merlintang . |
|
It's not urgent. Just I left two more comments. |
|
FYI. apache/spark#17710 |
|
thanks for letting me know. I will keep tack this information.
…On Tue, Jun 27, 2017 at 1:42 PM, Dongjoon Hyun ***@***.***> wrote:
FYI. apache/spark#17710 <apache/spark#17710>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#118 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABXY-chR5l0YONMaRxFzFvwzxvcZzaupks5sIWkfgaJpZM4NW8d1>
.
|
|
I will close this one, since I will open a new PR based on the latest updated branch-2.2. |
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)