Use warnings.catch_warnings instead of pytest.warns(None) in tests

horejsek · Nov 15, 2023 · 427a34e · 427a34e
1 parent 834c455
commit 427a34e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/tests/test_pattern_properties.py b/tests/test_pattern_properties.py
@@ -1,3 +1,5 @@
+import warnings
+
 import pytest
 
 
@@ -59,12 +61,11 @@ def test_pattern_with_escape_no_warnings(asserter):
         'bar': {}
     }
 
-    with pytest.warns(None) as record:
+    with warnings.catch_warnings():
+        warnings.simplefilter("error")
         asserter({
             'type': 'object',
             'patternProperties': {
                 '\\w+': {'type': 'object'}
             }
         }, value, value)
-
-    assert len(record) == 0
diff --git a/tests/test_string.py b/tests/test_string.py
@@ -1,3 +1,5 @@
+import warnings
+
 import pytest
 
 from fastjsonschema import JsonSchemaValueException
@@ -74,14 +76,13 @@ def test_pattern_with_space(asserter, pattern):
 
 
 def test_pattern_with_escape_no_warnings(asserter):
-    with pytest.warns(None) as record:
+    with warnings.catch_warnings():
+        warnings.simplefilter("error")
         asserter({
             'type': 'string',
             'pattern': '\\s'
         }, ' ', ' ')
 
-    assert len(record) == 0
-
 
 exc = JsonSchemaValueException('data must be a valid regex', value='{data}', name='data', definition='{definition}', rule='format')
 @pytest.mark.parametrize('value, expected', [