Skip to content
This repository has been archived by the owner on Jul 14, 2022. It is now read-only.

goreleaser setting version with ldflags #12

Merged
merged 1 commit into from
Feb 14, 2020
Merged

Conversation

gbmor
Copy link
Contributor

@gbmor gbmor commented Feb 14, 2020

Updated .goreleaser.yml to pass in the proper ldflags allowing the version to be set at deployment time.

I overlooked this earlier.

@athul
Copy link
Contributor

athul commented Feb 14, 2020

LGTM,
Thanks for this Ben, you're fast . I guess I may have to update the release again, right?

@athul athul merged commit 752994a into master Feb 14, 2020
@gbmor
Copy link
Contributor Author

gbmor commented Feb 14, 2020

It's up to you - this will mostly be a cosmetic change. Eg, when someone runs pwcli -v with the current release, if they're using a prebuilt binary from goreleaser there will be a blank version string.

@athul
Copy link
Contributor

athul commented Feb 14, 2020

Okay, we don't want blank version  😂, new release in a few minutes

@athul athul deleted the goreleaser_set_vers branch September 3, 2020 05:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants