explicitly close response body

hoppscotch · Feb 13, 2020 · fb3ec99 · fb3ec99
1 parent e7296b0
commit fb3ec99
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 6 deletions.
diff --git a/methods/delete.go b/methods/delete.go
@@ -32,7 +32,8 @@ func Deletebasic(c *cli.Context) error {
 	if err != nil {
 		return fmt.Errorf("Request error: %s", err.Error())
 	}
-	//defer resp.Body.Close()
+	defer resp.Body.Close()
+
 	s, err := formatresp(resp)
 	if err != nil {
 		return err

diff --git a/methods/get.go b/methods/get.go
@@ -31,6 +31,7 @@ func Getbasic(c *cli.Context) error {
 	if err != nil {
 		return fmt.Errorf("Error sending request: %s", err.Error())
 	}
+	defer resp.Body.Close()
 
 	s, err := formatresp(resp)
 	if err != nil {

diff --git a/methods/patch.go b/methods/patch.go
@@ -32,7 +32,8 @@ func Patchbasic(c *cli.Context) error {
 	if err != nil {
 		return fmt.Errorf("Error sending request: %s", err.Error())
 	}
-	//defer resp.Body.Close()
+	defer resp.Body.Close()
+
 	s, err := formatresp(resp)
 	if err != nil {
 		return err

diff --git a/methods/post.go b/methods/post.go
@@ -34,7 +34,8 @@ func Postbasic(c *cli.Context) error {
 	if err != nil {
 		return fmt.Errorf("Error sending request: %s", err.Error())
 	}
-	//defer resp.Body.Close()
+	defer resp.Body.Close()
+
 	s, err := formatresp(resp)
 	if err != nil {
 		return err

diff --git a/methods/put.go b/methods/put.go
@@ -32,7 +32,8 @@ func Putbasic(c *cli.Context) error {
 	if err != nil {
 		return fmt.Errorf("Error sending request: %s", err.Error())
 	}
-	//defer resp.Body.Close()
+	defer resp.Body.Close()
+
 	s, err := formatresp(resp)
 	if err != nil {
 		return err

diff --git a/methods/send.go b/methods/send.go
@@ -110,7 +110,7 @@ func getsend(c []Colls, ind int, method string) (string, error) {
 	if err != nil {
 		return "", fmt.Errorf("Error sending request: %s", err.Error())
 	}
-	//defer resp.Body.Close()
+	defer resp.Body.Close()
 	//fmt.Print(resp.Header)
 	s := color.Sprintf("Status: %s\tStatusCode:\t%d\n", resp.Status, resp.StatusCode)
 	return s, nil
@@ -145,7 +145,7 @@ func sendpopa(c []Colls, ind int, method string) (string, error) {
 	if err != nil {
 		return "", fmt.Errorf("Error sending request: %s", err.Error())
 	}
-	//defer resp.Body.Close()
+	defer resp.Body.Close()
 	//fmt.Print(resp.Header)
 	s := color.Sprintf("Status: %s\tStatusCode:\t%d\n", resp.Status, resp.StatusCode)
 	return s, nil