Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform 123 #69

Merged
merged 5 commits into from
Aug 13, 2020
Merged

Platform 123 #69

merged 5 commits into from
Aug 13, 2020

Conversation

joseph-mccombs
Copy link
Contributor

@joseph-mccombs joseph-mccombs commented Aug 13, 2020

Description of proposed changes

What does this pull request accomplish? Why should it be integrated?
This integrates a checkbox to allow users to agree to terms and service. It also adds a button to view the modal with the terms and service. Added scrollview to signUp as well.

Checklist

_Put an x in the boxes that apply. _

  • My lint and unit tests pass locally with my changes
  • I have added tests that prove my changes work (if applicable)
  • I have added or updated necessary documentation (if appropriate)

Additional comments

Is there anything else you want us to know?
The checkbox from react-paper is a bit clunky on ios. It's not the most straightforward and does NOT have a border. The android version of checkbox does however. We may want to use my previous checkbox library to accomplish the same thing, with a more uniform look.

domains/SignUp.js Outdated Show resolved Hide resolved
@hopetambala hopetambala merged commit bc7a45e into hopetambala:master Aug 13, 2020
hopetambala pushed a commit that referenced this pull request Feb 25, 2021
@joseph-mccombs joseph-mccombs deleted the PLATFORM-123 branch June 6, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants