fix: custom forms not loading in form gallery

hopetambala · Mar 30, 2022 · 68f1991 · 68f1991
1 parent 020a960
commit 68f1991
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/domains/DataCollection/FormGallery/FormsHorizontalView/index.js b/domains/DataCollection/FormGallery/FormsHorizontalView/index.js
@@ -6,6 +6,7 @@ import {
 import {
   Card, Text,
 } from 'react-native-paper';
+import uuid from 'react-native-uuid';
 
 import I18n from '../../../../modules/i18n';
 import { layout } from '../../../../modules/theme';
@@ -14,7 +15,7 @@ import styles from '../index.styles';
 const FormsHorizontalView = ({
   forms, header, navigateToCustomForm, pinForm
 }) => (
-  <View key={header} style={layout.screenRow}>
+  <View key={() => uuid.v4()} style={layout.screenRow}>
     {header && (
     <View style={{ flexDirection: 'row' }}>
       <Text style={styles.mediumHeader}>{header}</Text>
@@ -23,7 +24,7 @@ const FormsHorizontalView = ({
     <ScrollView horizontal>
       {forms.map((form) => (
         <Card
-          key={form.objectId}
+          key={() => uuid.v4() || form.objectId}
           style={layout.cardSmallStyle}
           onPress={() => {
             navigateToCustomForm(form);
@@ -41,7 +42,7 @@ const FormsHorizontalView = ({
       ))}
       {forms?.length < 1 && (
         <View style={layout.screenRow}>
-          <Card>
+          <Card key={() => uuid.v4()}>
             <Card.Title title={I18n.t('formsGallery.noCustomForms')} />
             {/* To be used when marketplace is available */}
             {/* <Card.Content>

diff --git a/domains/DataCollection/FormGallery/index.js b/domains/DataCollection/FormGallery/index.js
@@ -30,10 +30,8 @@ const FormGallery = ({
 
   useEffect(() => {
     getData('customForms').then((forms) => {
-      if (forms) {
-        setCustomForms(forms);
-        filterWorkflows(forms);
-      }
+      setCustomForms(forms || []);
+      filterWorkflows(forms || []);
     });
   }, [customForms]);