Health Checks V2 API #8
Conversation
|
|
about.go
Outdated
| @@ -53,11 +69,25 @@ type Dependency struct { | |||
| IsTraversable bool `json:"isTraversable"` | |||
| } | |||
|
|
|||
| type DependencyV2 struct { | |||
There was a problem hiding this comment.
Small nit here, we call this DependencyInfo in IDL
There was a problem hiding this comment.
I can change it
about.go
Outdated
| return dependencies | ||
| } | ||
|
|
||
| func statusEndpointsToDependenciesV2(statusEndpoints []StatusEndpoint) []Dependency { |
There was a problem hiding this comment.
Returns wrong type? Should this be DependencyV2?
about.go
Outdated
| return aboutV2(statusEndpoints, protocol, aboutFilePath, versionFilePath, customData, checkStatus) | ||
| } | ||
| // should never reach here | ||
| return "" |
There was a problem hiding this comment.
Do we want to give an error back or do we want to set a default when version is not valid?
There was a problem hiding this comment.
I think we should 400
There was a problem hiding this comment.
actually, how much do we care about this ? because it would fail in http.go before this is called. so maybe blank string as the default is fine when version is not valid ? Or we could make this a pointer and return nil plus error
http.go
Outdated
| dependencies = strings.Split(queryDependencies, ",") | ||
| } | ||
| apiVersion := APIV1 | ||
| if slug[2] == "v2" { |
There was a problem hiding this comment.
Do we care bout case here?
There was a problem hiding this comment.
I could do to lower 👍
| handleV1Api(w, r, slug[2], statusEndpoints, aboutFilePath, versionFilePath, customData) | ||
| case APIV2: | ||
| handleV2Api(w, r, slug[3], statusEndpoints, aboutFilePath, versionFilePath, customData) | ||
| } |
There was a problem hiding this comment.
What do we do for an invalid version?
There was a problem hiding this comment.
I can add a default that returns a status with invalid api version
There was a problem hiding this comment.
I think we should actually 400 for consistency with the about failure
There was a problem hiding this comment.
Should we think about consistency across languages here?
There was a problem hiding this comment.
hm what do we do as the fallback in scala for the API version invalid in any of the languages ?
This introduces a set of
/status/v2/endpoints for the health checks API.