Adding support for https cloning using github username and token prov… #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ided instead of using ssh
anubhavmishra
commented
Aug 13, 2017
models/models.go
Outdated
| SSHURL string | ||
| // CloneURL is the full HTTPS url for cloning. | ||
| // ex. "https://github.com/atlantis/atlantis.git". | ||
| CloneURL string |
There was a problem hiding this comment.
CloneURL used for logging instead of using the URL with username and password in it.
There was a problem hiding this comment.
What about keeping it clone url but naming the other one sanitizedcloneurl? No opinion, I like both.
lkysow
approved these changes
Aug 13, 2017
models/models.go
Outdated
| SSHURL string | ||
| // CloneURL is the full HTTPS url for cloning. | ||
| // ex. "https://github.com/atlantis/atlantis.git". | ||
| CloneURL string |
There was a problem hiding this comment.
What about keeping it clone url but naming the other one sanitizedcloneurl? No opinion, I like both.
|
nice! I'll give it another try |
malnick
pushed a commit
to BlueOwlDev/atlantis
that referenced
this pull request
Jun 21, 2018
Bootstrap is meant for a system that sets itself up. This command is more like a testing mode so I want to rename it to avoid confusion. Fixes hootsuite#129 and came out of hootsuite#117.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ided instead of using ssh
Fixes: #110