refactor(NLVObject): provide a reusable method for typed params

hooklift · Oct 10, 2016 · 1a30dea · 1a30dea
1 parent 74dc618
commit 1a30dea
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 29 deletions.
diff --git a/src/domain.cc b/src/domain.cc
@@ -907,35 +907,7 @@ NAN_METHOD(Domain::GetAllDomainStats)
         v8::Local<v8::Object> recordObject = Nan::New<v8::Object>();
         for (int i = 0; i < record->nparams; i++) {
           virTypedParameterPtr param = record->params + i;
-
-          v8::Local<v8::Value> value;
-          switch(param->type) {
-          case VIR_TYPED_PARAM_INT:
-            value = Nan::New<v8::Integer>(param->value.i);
-            break;
-          case VIR_TYPED_PARAM_UINT:
-            value = Nan::New<v8::Integer>(param->value.ui);
-            break;
-          case VIR_TYPED_PARAM_LLONG:
-            value = Nan::New<v8::Number>(param->value.l);
-            break;
-          case VIR_TYPED_PARAM_ULLONG:
-            value = Nan::New<v8::Number>(param->value.ul);
-            break;
-          case VIR_TYPED_PARAM_DOUBLE:
-            value = Nan::New<v8::Number>(param->value.d);
-            break;
-          case VIR_TYPED_PARAM_BOOLEAN:
-            value = Nan::New<v8::Boolean>(param->value.b);
-            break;
-          case VIR_TYPED_PARAM_STRING:
-            value = Nan::New(param->value.s).ToLocalChecked();
-            break;
-          default:
-            value = Nan::Null();
-          }
-
-          recordObject->Set(Nan::New(param->field).ToLocalChecked(), value);
+          recordObject->Set(Nan::New(param->field).ToLocalChecked(), extractTypedParameter(param));
         }
 
         std::string domain_name(virDomainGetName(record->dom));

diff --git a/src/nlv_object.h b/src/nlv_object.h
@@ -285,6 +285,40 @@ namespace NLV {
       worker->SaveToPersistent("parent", parent);
     Nan::AsyncQueueWorker(worker);
   }
+
+  NAN_INLINE v8::Local<v8::Value> extractTypedParameter(virTypedParameterPtr param) {
+    Nan::EscapableHandleScope scope;
+
+    v8::Local<v8::Value> value;
+    switch(param->type) {
+    case VIR_TYPED_PARAM_INT:
+      value = Nan::New<v8::Integer>(param->value.i);
+      break;
+    case VIR_TYPED_PARAM_UINT:
+      value = Nan::New<v8::Integer>(param->value.ui);
+      break;
+    case VIR_TYPED_PARAM_LLONG:
+      value = Nan::New<v8::Number>(param->value.l);
+      break;
+    case VIR_TYPED_PARAM_ULLONG:
+      value = Nan::New<v8::Number>(param->value.ul);
+      break;
+    case VIR_TYPED_PARAM_DOUBLE:
+      value = Nan::New<v8::Number>(param->value.d);
+      break;
+    case VIR_TYPED_PARAM_BOOLEAN:
+      value = Nan::New<v8::Boolean>(param->value.b);
+      break;
+    case VIR_TYPED_PARAM_STRING:
+      value = Nan::New(param->value.s).ToLocalChecked();
+      break;
+    default:
+      value = Nan::Null();
+    }
+
+    return scope.Escape(value);
+  }
+
 };
 
 #endif  // NLV_OBJECT_H