-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing semicolon #196
Conversation
@@ -15,7 +18,7 @@ snippet f | |||
${3} | |||
}${2:;} | |||
# Immediate function | |||
snippet (f | |||
snippet )f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this ok? It seems to me that (f
is a better snippet than )f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in case of (f
, parentheses auto-close plugin will give (f)
, that's annoying
What a bunch of merge commits. Why don't you use rebase instead? |
@iurifq thanks for reply |
Yeah, you can with |
Thank you! |
You should definitely clean them up. You can leave |
wait ,I will squash the commits |
I think it's ready to merge 😃 |
@honza can you take a look at this one? |
I'm not sure I like the |
Agreed @honza. What do you guys thing of |
While I totally appreciate the attempt to compromise, this just seems like it would defeat the purpose of having a snippet engine for most people. :) Personally, I have my shift keys remapped to |
I believe there are many people using plugins provide parentheses auto-close. |
UncleBilll: snipmate has a "rewrite" option, so it should be easy to find all keys having a ( and replace that with ) automatically. See SnippetsWithFolding example in documentation - however you want to change the keys, not the values. |
@MarcWeber I just checked out garbas/vim-snipmate#124. BTW, I am using Shougo/neosnippet.vim has alias feature, you can set alias for each snippet, multi alias is supported ( use |
Update:
add v for var