Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conninfo returns server IP #216

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Conversation

nakasyou
Copy link
Contributor

@nakasyou nakasyou commented Nov 9, 2024

Fixes #215.

Copy link

@shogo-kurokawa-nm shogo-kurokawa-nm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the issue! LGTM!

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@nakasyou @shogo-kurokawa-nm Thanks! I'll merge this and release a new version.

@yusukebe yusukebe merged commit c1b482c into honojs:main Nov 11, 2024
3 checks passed
@nakasyou nakasyou deleted the fix/conninfo branch November 11, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is the behavior of getConnInfo as expected ?
3 participants