Update Request to work with ReadableStream polyfills #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some web frameworks (like Remix) inject polyfills for ReadableStream and this change makes sure that the server will work correctly with those polyfills.
|
More info on Remix Polyfills:
I borrowed this check from the polyfill implementation here: |
|
Hi @nicksrandall ! Thanks for the PR. It looks good to me. One thing, could you run |
|
@yusukebe Done |
|
@nicksrandall Thanks! Merging now. |
nicolewhite
referenced
this pull request
in autoblocksai/cli
Apr 29, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@hono/node-server](https://togithub.com/honojs/node-server) | [`1.10.1` -> `1.11.1`](https://renovatebot.com/diffs/npm/@hono%2fnode-server/1.10.1/1.11.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>honojs/node-server (@​hono/node-server)</summary> ### [`v1.11.1`](https://togithub.com/honojs/node-server/releases/tag/v1.11.1) [Compare Source](https://togithub.com/honojs/node-server/compare/v1.11.0...v1.11.1) #### What's Changed - Update Request to work with ReadableStream polyfills by [@​nicksrandall](https://togithub.com/nicksrandall) in [https://github.com/honojs/node-server/pull/164](https://togithub.com/honojs/node-server/pull/164) - refactor(serve-static): use `c.req.path` instead of `url.pathname` by [@​yusukebe](https://togithub.com/yusukebe) in [https://github.com/honojs/node-server/pull/166](https://togithub.com/honojs/node-server/pull/166) #### New Contributors - [@​nicksrandall](https://togithub.com/nicksrandall) made their first contribution in [https://github.com/honojs/node-server/pull/164](https://togithub.com/honojs/node-server/pull/164) **Full Changelog**: honojs/node-server@v1.11.0...v1.11.1 ### [`v1.11.0`](https://togithub.com/honojs/node-server/releases/tag/v1.11.0) [Compare Source](https://togithub.com/honojs/node-server/compare/v1.10.1...v1.11.0) #### What's Changed - feat: validate incoming host header by [@​usualoma](https://togithub.com/usualoma) in [https://github.com/honojs/node-server/pull/163](https://togithub.com/honojs/node-server/pull/163) **Full Changelog**: honojs/node-server@v1.10.1...v1.11.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" in timezone America/Chicago, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/autoblocksai/cli). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMyMS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
This was referenced Sep 17, 2024
This was referenced Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some web frameworks (like Remix) inject polyfills for ReadableStream into the Node Runtime. This change makes sure that the server will work correctly with those polyfills. Otherwise the
instanceofcheck would fail.