Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ignore response if already sent by raw level outgoing API. #153

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

usualoma
Copy link
Member

No description provided.

@usualoma usualoma marked this pull request as ready for review March 25, 2024 07:04
Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

Hi @usualoma

Thanks! This is a good and simple solution. Let's go with this.

@yusukebe yusukebe merged commit 3fc502a into honojs:main Mar 25, 2024
3 checks passed
@usualoma usualoma deleted the feat/skip-response-if-already-sent branch March 25, 2024 08:50
nicolewhite referenced this pull request in autoblocksai/cli Apr 15, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@hono/node-server](https://togithub.com/honojs/node-server) |
[`1.8.2` ->
`1.10.0`](https://renovatebot.com/diffs/npm/@hono%2fnode-server/1.8.2/1.10.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@hono%2fnode-server/1.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@hono%2fnode-server/1.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@hono%2fnode-server/1.8.2/1.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@hono%2fnode-server/1.8.2/1.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>honojs/node-server (@&#8203;hono/node-server)</summary>

###
[`v1.10.0`](https://togithub.com/honojs/node-server/releases/tag/v1.10.0)

[Compare
Source](https://togithub.com/honojs/node-server/compare/v1.9.1...v1.10.0)

#### What's Changed

- feat: enable to skip overriding global Request and Response classes by
[@&#8203;usualoma](https://togithub.com/usualoma) in
[https://github.com/honojs/node-server/pull/156](https://togithub.com/honojs/node-server/pull/156)
- docs(readme): update by
[@&#8203;yusukebe](https://togithub.com/yusukebe) in
[https://github.com/honojs/node-server/pull/157](https://togithub.com/honojs/node-server/pull/157)

**Full Changelog**:
honojs/node-server@v1.9.1...v1.10.0

###
[`v1.9.1`](https://togithub.com/honojs/node-server/releases/tag/v1.9.1)

[Compare
Source](https://togithub.com/honojs/node-server/compare/v1.9.0...v1.9.1)

#### What's Changed

- fix(request): guess request protocol from incoming object by
[@&#8203;usualoma](https://togithub.com/usualoma) in
[https://github.com/honojs/node-server/pull/155](https://togithub.com/honojs/node-server/pull/155)

**Full Changelog**:
honojs/node-server@v1.9.0...v1.9.1

###
[`v1.9.0`](https://togithub.com/honojs/node-server/releases/tag/v1.9.0)

[Compare
Source](https://togithub.com/honojs/node-server/compare/v1.8.2...v1.9.0)

#### What's Changed

- feat: ignore response if already sent by raw level outgoing API. by
[@&#8203;usualoma](https://togithub.com/usualoma) in
[https://github.com/honojs/node-server/pull/153](https://togithub.com/honojs/node-server/pull/153)

**Full Changelog**:
honojs/node-server@v1.8.2...v1.9.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on Monday" in timezone
America/Chicago, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/autoblocksai/cli).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Nicole White <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants