feat(listener): support custom error handler #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marc MacLeod <[email protected]>
1 task
yusukebe
reviewed
Jan 27, 2024
|
Hi @marbemac ! This is an awesome feature! I have been wanting a feature like this. Please check my comments. Also, please add proper tests. Thanks. |
Signed-off-by: Marc MacLeod <[email protected]>
Signed-off-by: Marc MacLeod <[email protected]>
Signed-off-by: Marc MacLeod <[email protected]> # Conflicts: # src/listener.ts
|
Hi @yusukebe - alrighty, I've adjusted the function signature to accept the options object, and added some tests. LMK if the code style / test style works for you, or if you'd like any other changes! |
Signed-off-by: Marc MacLeod <[email protected]>
|
Hi @marbemac Please run: yarn lint:fix && yarn format:fix |
Signed-off-by: Marc MacLeod <[email protected]>
|
done |
|
Greeeat! I'll merge it and ship the new version. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would ya'll be open to this kind of option?
Open to alternative approaches, but basically what I'm after is a means for the consumer to be able to provide it's own error handler so that it can, for example, pass the error down the middleware chain in a Vite dev server. This allows vite to display the standard pretty error overlay on the client, etc.
See example of how it can be used in honojs/vite-plugins#63 (this PR blocks that PR).