feat(powered-by): optional server name

[PatrickJS]

The author should do the following, if applicable

• Add tests
• Run tests
• bun run format:fix && bun run lint:fix to format the code
• Add TSDoc/JSDoc to document the code

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.57%. Comparing base (31b4cd4) to head (733e7bc).
Report is 10 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3492      +/-   ##
==========================================
- Coverage   95.58%   95.57%   -0.02%     
==========================================
  Files         155      155              
  Lines        9357     9357              
  Branches     2730     2737       +7     
==========================================
- Hits         8944     8943       -1     
- Misses        413      414       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yusukebe]

Hi @PatrickJS

Thank you for the PR. This is good! It is a new feature but we can introduce it in the next patch release because it's not such a big change.

There should be tests. Can you add tests?

[yusukebe]

@PatrickJS

I think making the option as an object, not a string, is good. Like the following:

diff --git a/src/middleware/powered-by/index.ts b/src/middleware/powered-by/index.ts
index caa3be7c..4db425f9 100644
--- a/src/middleware/powered-by/index.ts
+++ b/src/middleware/powered-by/index.ts
@@ -5,9 +5,13 @@

 import type { MiddlewareHandler } from '../../types'

-export const poweredBy = (serverName = 'Hono'): MiddlewareHandler => {
+type PoweredByOptions = {
+  serverName?: string
+}
+
+export const poweredBy = (options?: PoweredByOptions): MiddlewareHandler => {
   return async function poweredBy(c, next) {
     await next()
-    c.res.headers.set('X-Powered-By', serverName)
+    c.res.headers.set('X-Powered-By', options?.serverName ?? 'Hono')
   }
 }

[PatrickJS]

ok made the changes thanks

[yusukebe]

@PatrickJS

Thanks! Can you add a test?

[PatrickJS]

yup just did 🫡

[PatrickJS]

done done

[yusukebe]

LGTM!

[yusukebe]

Thanks @PatrickJS !

Looks good. I'll merge this later and will include this change in the next patch release. It's a new feat but it's small. We don't have to wait for the release of the next minor version.