Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jsx-renderer): set Content-Encoding when stream is true #3355

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

yusukebe
Copy link
Member

@yusukebe yusukebe commented Sep 1, 2024

With this PR, if the stream is true, it will set Content-Encoding as Identity. This is needed to correct the behavior of Suspense when the content is encoded like gzip.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.76%. Comparing base (bdaaa7f) to head (d39bb4d).
Report is 9 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff            @@
##             next    #3355    +/-   ##
========================================
  Coverage   95.76%   95.76%            
========================================
  Files         151      151            
  Lines        9186     9187     +1     
  Branches     2708     2817   +109     
========================================
+ Hits         8797     8798     +1     
  Misses        389      389            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yusukebe yusukebe added the v4.6 label Sep 4, 2024
@yusukebe yusukebe changed the base branch from main to next September 8, 2024 06:49
@yusukebe yusukebe merged commit 39600c4 into next Sep 8, 2024
14 checks passed
@yusukebe yusukebe deleted the feat/jsx-renderer-content-encoding branch September 8, 2024 06:50
@yusukebe yusukebe mentioned this pull request Sep 11, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant