-
-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(secureHeader): add Permissions-Policy header to secure headers middleware #3314
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #3314 +/- ##
==========================================
- Coverage 96.31% 95.77% -0.54%
==========================================
Files 151 153 +2
Lines 15368 9214 -6154
Branches 2693 2828 +135
==========================================
- Hits 14801 8825 -5976
+ Misses 567 389 -178 ☔ View full report in Codecov by Sentry. |
Hi @kbkn3 Thank you for the PR! @watany-dev Can you review this? |
@watany-dev Thank you for reviewing. @kbkn3 Can you take a look? |
@watany-dev Thank you for reviewing. @yusukebe Sorry for the delay in response. Fixed. |
@watany-dev Thank you for reviewing!! @kbkn3 Last one thing. Can you run |
87eac2b
to
00b9d70
Compare
@yusukebe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you! Let's go with it. This is a new feature so that it will be included in the next new minor version, |
@yusukebe I enjoy developing with |
…iddleware
Summary
Permissions-Policy was added to Secure Headers Middleware.
For more information on Permissions-Policy, please refer to the following.
EN: Permissions-Policy | MDN Web Docs
EN: Permissions Policy - HTTP | MDN
JA: Permissions-Policy - HTTP | MDN
JA: Permissions Policy - HTTP | MDN
Documetn Policy, which is listed as a similar Header, is not a Security requirement and does not need to be addressed.
The author should do the following, if applicable
bun run format:fix && bun run lint:fix
to format the code