refactor(request): shorten parseBody and remove unnecessary check

[yusukebe]

This refactoring shortens code inside parseBody and removes an unnecessary conditional check.

The author should do the following, if applicable

• Add tests
• Run tests
• bun run format:fix && bun run lint:fix to format the code
• Add TSDoc/JSDoc to document the code

[yusukebe]

This condition never triggered.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.64%. Comparing base (0a974ff) to head (42f0797).
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2947      +/-   ##
==========================================
+ Coverage   94.44%   94.64%   +0.20%     
==========================================
  Files         136      136              
  Lines       13349    13341       -8     
  Branches     2284     2234      -50     
==========================================
+ Hits        12607    12627      +20     
+ Misses        742      714      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yusukebe]

Hi @usualoma Please review this one too!

[usualoma]

Hi @yusukebe
Confirmed. Good!

How about organising it a bit more as follows.

diff --git a/src/request.ts b/src/request.ts
index fbec9dcf..64801ef5 100644
--- a/src/request.ts
+++ b/src/request.ts
@@ -213,17 +213,14 @@ export class HonoRequest<P extends string = '/', I extends Input['out'] = {}> {
       return cachedBody
     }
 
-    if (!bodyCache[key]) {
-      for (const keyOfBodyCache of Object.keys(bodyCache)) {
-        return (async () => {
-          // @ts-expect-error bodyCache[keyOfBodyCache] can be passed as a body
-          let body = await bodyCache[keyOfBodyCache]
-          if (keyOfBodyCache === 'json') {
-            body = JSON.stringify(body)
-          }
-          return await new Response(body)[key]()
-        })()
-      }
+    const anyCachedKey = Object.keys(bodyCache)[0]
+    if (anyCachedKey) {
+      return (bodyCache[anyCachedKey as keyof Body] as Promise<BodyInit>).then((body) => {
+        if (anyCachedKey === 'json') {
+          body = JSON.stringify(body)
+        }
+        return new Response(body)[key]()
+      })
     }
 
     return (bodyCache[key] = raw[key]())

[yusukebe]

@usualoma

Thanks for the review. You are right. It does not need the loop! Let's go with it.