fix(types): SimplifyDeepArray should now actually be "deep"
#2920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also now uses `Simplify` instead of inline declare the type
DRY-er code and fixes a weird type is possibly infinite yelling
|
@yusukebe please help me review it, thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2920 +/- ##
========================================
Coverage 94.11% 94.11%
========================================
Files 136 136
Lines 13382 13384 +2
Branches 2242 2348 +106
========================================
+ Hits 12594 12596 +2
Misses 788 788 ☔ View full report in Codecov by Sentry. |
|
@NamesMT Great work! Thanks! |
nicolewhite
referenced
this pull request
in autoblocksai/cli
Jun 10, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [hono](https://hono.dev/) ([source](https://togithub.com/honojs/hono)) | [`4.4.0` -> `4.4.4`](https://renovatebot.com/diffs/npm/hono/4.4.0/4.4.4) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>honojs/hono (hono)</summary> ### [`v4.4.4`](https://togithub.com/honojs/hono/releases/tag/v4.4.4) [Compare Source](https://togithub.com/honojs/hono/compare/v4.4.3...v4.4.4) ##### What's Changed - fix(typo): Fix typo in request.test.ts by [@​yasuaki640](https://togithub.com/yasuaki640) in [https://github.com/honojs/hono/pull/2899](https://togithub.com/honojs/hono/pull/2899) - feat(hono-base): skip import HTTPException by using HTTPResponseError by [@​usualoma](https://togithub.com/usualoma) in [https://github.com/honojs/hono/pull/2898](https://togithub.com/honojs/hono/pull/2898) - chore: improve unfinalized response error by [@​Cherry](https://togithub.com/Cherry) in [https://github.com/honojs/hono/pull/2902](https://togithub.com/honojs/hono/pull/2902) - chore: create .gitpod.yml by [@​EdamAme-x](https://togithub.com/EdamAme-x) in [https://github.com/honojs/hono/pull/2868](https://togithub.com/honojs/hono/pull/2868) - fix(cloudflare-workers): export getConnInfo() by [@​ryuapp](https://togithub.com/ryuapp) in [https://github.com/honojs/hono/pull/2906](https://togithub.com/honojs/hono/pull/2906) - fix(hono-base): return 404 if lacking response in a single sync handler by [@​yusukebe](https://togithub.com/yusukebe) in [https://github.com/honojs/hono/pull/2909](https://togithub.com/honojs/hono/pull/2909) - refactor: remove `Prettify` as duplicated with `Simplify` by [@​NamesMT](https://togithub.com/NamesMT) in [https://github.com/honojs/hono/pull/2914](https://togithub.com/honojs/hono/pull/2914) - fix(types): [#​2912](https://togithub.com/honojs/hono/issues/2912): interfaces array's respond typed as `never` by [@​NamesMT](https://togithub.com/NamesMT) in [https://github.com/honojs/hono/pull/2915](https://togithub.com/honojs/hono/pull/2915) - feat(context): `c.redirect()` supports `TypedResponse` by [@​yusukebe](https://togithub.com/yusukebe) in [https://github.com/honojs/hono/pull/2908](https://togithub.com/honojs/hono/pull/2908) - feat(jsx): support htmlfor attribute alias by [@​akira-tsuno](https://togithub.com/akira-tsuno) in [https://github.com/honojs/hono/pull/2916](https://togithub.com/honojs/hono/pull/2916) - fix(filepath): allow suffix includes `-` and `_` by [@​yusukebe](https://togithub.com/yusukebe) in [https://github.com/honojs/hono/pull/2910](https://togithub.com/honojs/hono/pull/2910) - fix(types): add `_` prefix to `TypedResponse` properties by [@​yusukebe](https://togithub.com/yusukebe) in [https://github.com/honojs/hono/pull/2917](https://togithub.com/honojs/hono/pull/2917) - fix(types): `SimplifyDeepArray` should now actually be "deep" by [@​NamesMT](https://togithub.com/NamesMT) in [https://github.com/honojs/hono/pull/2920](https://togithub.com/honojs/hono/pull/2920) - refactor(middleware/serve-static): call getContent only once if the file does not exist by [@​usualoma](https://togithub.com/usualoma) in [https://github.com/honojs/hono/pull/2922](https://togithub.com/honojs/hono/pull/2922) - chore: add `text` and `html` for coverage reporter by [@​yusukebe](https://togithub.com/yusukebe) in [https://github.com/honojs/hono/pull/2923](https://togithub.com/honojs/hono/pull/2923) - refactor(conninfo): create `types.ts` for type definitions by [@​yusukebe](https://togithub.com/yusukebe) in [https://github.com/honojs/hono/pull/2924](https://togithub.com/honojs/hono/pull/2924) ##### New Contributors - [@​yasuaki640](https://togithub.com/yasuaki640) made their first contribution in [https://github.com/honojs/hono/pull/2899](https://togithub.com/honojs/hono/pull/2899) - [@​Cherry](https://togithub.com/Cherry) made their first contribution in [https://github.com/honojs/hono/pull/2902](https://togithub.com/honojs/hono/pull/2902) - [@​akira-tsuno](https://togithub.com/akira-tsuno) made their first contribution in [https://github.com/honojs/hono/pull/2916](https://togithub.com/honojs/hono/pull/2916) **Full Changelog**: honojs/hono@v4.4.3...v4.4.4 ### [`v4.4.3`](https://togithub.com/honojs/hono/releases/tag/v4.4.3) [Compare Source](https://togithub.com/honojs/hono/compare/v4.4.2...v4.4.3) ##### What's Changed - ci: Update workflow name of release.yml by [@​siguici](https://togithub.com/siguici) in [https://github.com/honojs/hono/pull/2874](https://togithub.com/honojs/hono/pull/2874) - refactor: removed unnecessary line by [@​EdamAme-x](https://togithub.com/EdamAme-x) in [https://github.com/honojs/hono/pull/2869](https://togithub.com/honojs/hono/pull/2869) - ci: change name of workflow jobs by [@​EdamAme-x](https://togithub.com/EdamAme-x) in [https://github.com/honojs/hono/pull/2875](https://togithub.com/honojs/hono/pull/2875) - docs(jsdoc): add jsdoc of some modules by [@​EdamAme-x](https://togithub.com/EdamAme-x) in [https://github.com/honojs/hono/pull/2836](https://togithub.com/honojs/hono/pull/2836) - ci: Report coverage with CodeCov by [@​exoego](https://togithub.com/exoego) in [https://github.com/honojs/hono/pull/2862](https://togithub.com/honojs/hono/pull/2862) - docs: update readme and migrate guide for migrating `deno.land/x` to JSR by [@​yusukebe](https://togithub.com/yusukebe) in [https://github.com/honojs/hono/pull/2879](https://togithub.com/honojs/hono/pull/2879) - chore: add coverage badge to README by [@​exoego](https://togithub.com/exoego) in [https://github.com/honojs/hono/pull/2881](https://togithub.com/honojs/hono/pull/2881) - fix(websocket): the onopen event cannot be triggered during delayed operations in deno by [@​JetLua](https://togithub.com/JetLua) in [https://github.com/honojs/hono/pull/2864](https://togithub.com/honojs/hono/pull/2864) - fix(cloudflare-workers): Update websocket.ts to return 101 status code by [@​ronkeiser](https://togithub.com/ronkeiser) in [https://github.com/honojs/hono/pull/2886](https://togithub.com/honojs/hono/pull/2886) - test(workerd): rename the runtime test `wrangler` to `workerd` by [@​yusukebe](https://togithub.com/yusukebe) in [https://github.com/honojs/hono/pull/2888](https://togithub.com/honojs/hono/pull/2888) - test(workerd): add tests for WebSocket by [@​yusukebe](https://togithub.com/yusukebe) in [https://github.com/honojs/hono/pull/2891](https://togithub.com/honojs/hono/pull/2891) - refactor(aws-lambda): merge custom-context into types by [@​exoego](https://togithub.com/exoego) in [https://github.com/honojs/hono/pull/2889](https://togithub.com/honojs/hono/pull/2889) - chore: Exclude type-only files from coverage by [@​exoego](https://togithub.com/exoego) in [https://github.com/honojs/hono/pull/2890](https://togithub.com/honojs/hono/pull/2890) - test(presets): add tests for `hono/quick` and `hono/tiny` by [@​yusukebe](https://togithub.com/yusukebe) in [https://github.com/honojs/hono/pull/2892](https://togithub.com/honojs/hono/pull/2892) - fix(types): fix typo for unofficial status code type by [@​ryuapp](https://togithub.com/ryuapp) in [https://github.com/honojs/hono/pull/2894](https://togithub.com/honojs/hono/pull/2894) - feat(hono-base): add `replaceRequest` option for `app.mount` by [@​yusukebe](https://togithub.com/yusukebe) in [https://github.com/honojs/hono/pull/2852](https://togithub.com/honojs/hono/pull/2852) ##### New Contributors - [@​siguici](https://togithub.com/siguici) made their first contribution in [https://github.com/honojs/hono/pull/2874](https://togithub.com/honojs/hono/pull/2874) - [@​JetLua](https://togithub.com/JetLua) made their first contribution in [https://github.com/honojs/hono/pull/2864](https://togithub.com/honojs/hono/pull/2864) - [@​ronkeiser](https://togithub.com/ronkeiser) made their first contribution in [https://github.com/honojs/hono/pull/2886](https://togithub.com/honojs/hono/pull/2886) **Full Changelog**: honojs/hono@v4.4.2...v4.4.3 ### [`v4.4.2`](https://togithub.com/honojs/hono/releases/tag/v4.4.2) [Compare Source](https://togithub.com/honojs/hono/compare/v4.4.1...v4.4.2) #### What's Changed - fix: add return types of void function by [@​EdamAme-x](https://togithub.com/EdamAme-x) in [https://github.com/honojs/hono/pull/2870](https://togithub.com/honojs/hono/pull/2870) **Full Changelog**: honojs/hono@v4.4.1...v4.4.2 ### [`v4.4.1`](https://togithub.com/honojs/hono/releases/tag/v4.4.1) [Compare Source](https://togithub.com/honojs/hono/compare/v4.4.0...v4.4.1) #### What's Changed - refactor(pretty-json): remove useless condition by [@​6km](https://togithub.com/6km) in [https://github.com/honojs/hono/pull/2815](https://togithub.com/honojs/hono/pull/2815) - fix(aws-lambda): Update handler.ts getQueryString by [@​qualipsolutions](https://togithub.com/qualipsolutions) in [https://github.com/honojs/hono/pull/2782](https://togithub.com/honojs/hono/pull/2782) - refactor(aws-lambda): Object.hasOwn is recommended by [@​exoego](https://togithub.com/exoego) in [https://github.com/honojs/hono/pull/2831](https://togithub.com/honojs/hono/pull/2831) - fix(client): allow multiple files on the same key in form by [@​olivier-drieux](https://togithub.com/olivier-drieux) in [https://github.com/honojs/hono/pull/2791](https://togithub.com/honojs/hono/pull/2791) - fix(helper/ssg): fix bug of joinPaths by [@​EdamAme-x](https://togithub.com/EdamAme-x) in [https://github.com/honojs/hono/pull/2809](https://togithub.com/honojs/hono/pull/2809) - chore: Author should include JSDoc by [@​fzn0x](https://togithub.com/fzn0x) in [https://github.com/honojs/hono/pull/2840](https://togithub.com/honojs/hono/pull/2840) - fix(middleware/body-limit): set default duplex option for readable stream by [@​fzn0x](https://togithub.com/fzn0x) in [https://github.com/honojs/hono/pull/2837](https://togithub.com/honojs/hono/pull/2837) - refactor(websocket): remove unused condition by [@​fzn0x](https://togithub.com/fzn0x) in [https://github.com/honojs/hono/pull/2839](https://togithub.com/honojs/hono/pull/2839) - feat(bun): WebSocket helper supports that env be `{ server: server }` by [@​nakasyou](https://togithub.com/nakasyou) in [https://github.com/honojs/hono/pull/2812](https://togithub.com/honojs/hono/pull/2812) - refactor: added paths-ignore for ignore files of dont need tests by [@​EdamAme-x](https://togithub.com/EdamAme-x) in [https://github.com/honojs/hono/pull/2850](https://togithub.com/honojs/hono/pull/2850) - ci: include node22 tests by [@​Jayllyz](https://togithub.com/Jayllyz) in [https://github.com/honojs/hono/pull/2851](https://togithub.com/honojs/hono/pull/2851) - docs(src/\*): Add TSDoc comments to improve code documentation by [@​fzn0x](https://togithub.com/fzn0x) in [https://github.com/honojs/hono/pull/2841](https://togithub.com/honojs/hono/pull/2841) - fix(types): allow blank env by [@​fzn0x](https://togithub.com/fzn0x) in [https://github.com/honojs/hono/pull/2834](https://togithub.com/honojs/hono/pull/2834) - refactor: removed v4 branch in actions. by [@​EdamAme-x](https://togithub.com/EdamAme-x) in [https://github.com/honojs/hono/pull/2849](https://togithub.com/honojs/hono/pull/2849) - refactor(helper/adapter): improve runtime detection by [@​6km](https://togithub.com/6km) in [https://github.com/honojs/hono/pull/2846](https://togithub.com/honojs/hono/pull/2846) - fix(jsx/dom): Fixed to not add "px" for certain properties, even if numeric value is given by [@​usualoma](https://togithub.com/usualoma) in [https://github.com/honojs/hono/pull/2845](https://togithub.com/honojs/hono/pull/2845) - refactor(aws-lambda): remove unused setHeadersToResult by [@​exoego](https://togithub.com/exoego) in [https://github.com/honojs/hono/pull/2828](https://togithub.com/honojs/hono/pull/2828) - fix(validator): support json api header by [@​dil-borosz](https://togithub.com/dil-borosz) in [https://github.com/honojs/hono/pull/2855](https://togithub.com/honojs/hono/pull/2855) - refactor(helper/testing): remove some any of helper/testing by [@​EdamAme-x](https://togithub.com/EdamAme-x) in [https://github.com/honojs/hono/pull/2833](https://togithub.com/honojs/hono/pull/2833) - docs: change to shell highlight by [@​EdamAme-x](https://togithub.com/EdamAme-x) in [https://github.com/honojs/hono/pull/2848](https://togithub.com/honojs/hono/pull/2848) - refactor(compose): Remove type definition of ComposeContext that was defined twice by [@​chimame](https://togithub.com/chimame) in [https://github.com/honojs/hono/pull/2858](https://togithub.com/honojs/hono/pull/2858) #### New Contributors - [@​6km](https://togithub.com/6km) made their first contribution in [https://github.com/honojs/hono/pull/2815](https://togithub.com/honojs/hono/pull/2815) - [@​qualipsolutions](https://togithub.com/qualipsolutions) made their first contribution in [https://github.com/honojs/hono/pull/2782](https://togithub.com/honojs/hono/pull/2782) - [@​olivier-drieux](https://togithub.com/olivier-drieux) made their first contribution in [https://github.com/honojs/hono/pull/2791](https://togithub.com/honojs/hono/pull/2791) - [@​Jayllyz](https://togithub.com/Jayllyz) made their first contribution in [https://github.com/honojs/hono/pull/2851](https://togithub.com/honojs/hono/pull/2851) - [@​dil-borosz](https://togithub.com/dil-borosz) made their first contribution in [https://github.com/honojs/hono/pull/2855](https://togithub.com/honojs/hono/pull/2855) - [@​chimame](https://togithub.com/chimame) made their first contribution in [https://github.com/honojs/hono/pull/2858](https://togithub.com/honojs/hono/pull/2858) **Full Changelog**: honojs/hono@v4.4.0...v4.4.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" in timezone America/Chicago, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/autoblocksai/cli). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2878
#2915 added
SimplifyDeepArraybut it wasn't actually deep so nested interface array was still bugged asnever.It is now actually deep and should fix that.
I have also split JSONRespond's return declaration to
JSONRespondReturntype for DRY-er code structure because of some weird bug with typescript yellingtype is possibly infiniteat line ~664 whenReturnType<JSONRespond>is used as return declaration,We could remove this type-split commit and put the full type declaration at line ~668 if you prefer not splitting it.
The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code