Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helper): fix bug of joinPaths #2798

Closed
wants to merge 3 commits into from

Conversation

EdamAme-x
Copy link
Contributor

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code

@EdamAme-x
Copy link
Contributor Author

Before
("..", "..") => ("..")
this is bug

After
("..", "..") => ("../..")

@yusukebe
Copy link
Member

Hi @EdamAme-x

Thanks for the PR. I'll review it, but please wait until releasing v4.4. It will be shipped tomorrow.

@EdamAme-x
Copy link
Contributor Author

I understood. thanks!

@yusukebe yusukebe deleted the branch honojs:next May 27, 2024 07:31
@yusukebe yusukebe closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants