-
-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Introduce ConnInfo helper/adapter #2595
Conversation
CI fails. Could you run |
I ran If strings include single quote, CI fails due to Prettier or ESLint. Prettier recommends |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hey @nakasyou Looks great! It's finished. This is a new feature, so I'm planning to release it in the next minor release, |
@yusukebe, I see. Thanks! |
Hello,
However, I get the following error. Is this because this is not yet available in
Thank you. |
Now import { Hono } from 'jsr:@hono/hono'
import { getConnInfo } from 'jsr:@hono/hono/deno' |
I created ConnInfo helper/adapter for Bun, Deno and CF Workers.
You can get client IP Address with Hono easier if we marge PR.
This provides runtime-less ConnInfo object.
For example, you can get IP Address on Bun:
If you want to use Workers, replace import:
In Deno:
Author should do the followings, if applicable
bun denoify
to generate files for Deno