Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add onNotFound handler in adapters' serveStatic #1825

Merged
merged 3 commits into from
Dec 26, 2023
Merged

feat: Add onNotFound handler in adapters' serveStatic #1825

merged 3 commits into from
Dec 26, 2023

Conversation

Th1nkK1D
Copy link
Contributor

@Th1nkK1D Th1nkK1D commented Dec 15, 2023 •
edited
Loading

Resolve #1810

Author should do the followings, if applicable

  • Add tests
  • Run tests
  • yarn denoify to generate files for Deno

@Th1nkK1D Th1nkK1D changed the title [WIP] Add onNotFound handler in adapters' serveStatic Add onNotFound handler in adapters' serveStatic Dec 18, 2023
@Th1nkK1D Th1nkK1D changed the title Add onNotFound handler in adapters' serveStatic feat: Add onNotFound handler in adapters' serveStatic Dec 18, 2023
@Th1nkK1D Th1nkK1D mentioned this pull request Dec 18, 2023
Closed
@yusukebe
Copy link
Member

Hi @Th1nkK1D

Looks good!

You can prevent the CI test on Bun from failing by using the latest version of Bun. In PR #1832, I've updated the Bun version used in CI and merged it. So, please merge the main branch into this branch and then push the changes.

@yusukebe yusukebe added the v3.12 label Dec 18, 2023
@Th1nkK1D
Copy link
Contributor Author

You can prevent the CI test on Bun from failing by using the latest version of Bun. In PR #1832, I've updated the Bun version used in CI and merged it. So, please merge the main branch into this branch and then push the changes.

Forgot to mention that it was done ;)

@yusukebe yusukebe changed the base branch from main to next December 23, 2023 00:52
@yusukebe yusukebe deleted the branch honojs:next December 26, 2023 21:53
@yusukebe yusukebe closed this Dec 26, 2023
@yusukebe yusukebe reopened this Dec 26, 2023
@yusukebe yusukebe merged commit b128d02 into honojs:next Dec 26, 2023
22 checks passed
This was referenced Jan 1, 2024
Closed
Merged
nakasyou pushed a commit to nakasyou/hono that referenced this pull request Jan 13, 2024
@Th1nkK1D @nakasyou
feat: Add onNotFound handler in adapters' serveStatic (honojs#1825)
6d8b52a 
* feat: add onNotFound handler in adapters' serveStatic

* test: add serveStatic onNotFound tests for bun and deno

* test: add serveStatic onNotFound tests for cloudflare workers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow turning off console.warn when 404 on Bun serveStatic adapter
2 participants
@Th1nkK1D @yusukebe