Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(adapter): AWS Lambda Adapter supports requests via Lambda@edge #1210

Merged
merged 16 commits into from
Jul 7, 2023

Conversation

watany-dev
Copy link
Contributor

@watany-dev
Copy link
Contributor Author

watany-dev commented Jun 29, 2023

Please let me know if I should separate this commit from the API and make it as adaptor/aws-lambda-edge :)

@yusukebe
Copy link
Member

yusukebe commented Jul 1, 2023

Hi @watany-dev !

Thanks for the PR. Supporting Lambda@Edge is indeed something we are interested in.

Please let me know if I should separate this commit from the API and make it as adaptor/aws-lambda-edge :)

Yes, it would be best to separate the adapter from adapter/aws-lambda and make this standalone. I believe naming it adapter/lambda-edge would be appropriate:

Screenshot 2023-07-01 at 17 25 00 Screenshot 2023-07-01 at 17 25 07

@yusukebe
Copy link
Member

yusukebe commented Jul 3, 2023

Hi @watany-dev

Is this still working progress?

@watany-dev
Copy link
Contributor Author

@yusukebe
Yes, I have fetched the latest materials and am in the process of working on it. Since I haven't been able to write the tests yet, I think it will take a few more days.

@yusukebe
Copy link
Member

yusukebe commented Jul 3, 2023

@watany-dev

Okay!

@watany-dev
Copy link
Contributor Author

@yusukebe
Thanks for waiting. We were able to create it successfully.

@yusukebe
Copy link
Member

yusukebe commented Jul 7, 2023

@watany-dev

Finally, you did it. Thank you! I'll merge now!!

@yusukebe yusukebe merged commit edca699 into honojs:main Jul 7, 2023
@watany-dev watany-dev deleted the lambda@edge-adaptor branch July 7, 2023 08:58
@yusukebe
Copy link
Member

yusukebe commented Jul 7, 2023

@watany-dev

If you feel up to it, could you write the document like "AWS Lambda" on website? Repository is here. But, you don't have to do it.

@watany-dev
Copy link
Contributor Author

@yusukebe
Thank you for the wonderful offer. My writing might not be able to start until after July 14th. If that's okay, please allow me to contribute.

@yusukebe
Copy link
Member

yusukebe commented Jul 7, 2023

@watany-dev

That's OK! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants