fix(rpc): infer path with route() and basePath() (#1401)

* fix(rpc): infer path with `route()` and `basePath()` * denoify
honojs · Sep 3, 2023 · d194e9b · d194e9b
1 parent 4550b31
commit d194e9b
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 4 deletions.
diff --git a/deno_dist/hono-base.ts b/deno_dist/hono-base.ts
@@ -147,7 +147,7 @@ class Hono<
   >(
     path: SubPath,
     app: Hono<SubEnv, SubSchema, SubBasePath>
-  ): Hono<E, MergeSchemaPath<SubSchema, SubPath> & S, BasePath>
+  ): Hono<E, MergeSchemaPath<SubSchema, MergePath<BasePath, SubPath>> & S, BasePath>
   /** @description
    * Use `basePath` instead of `route` when passing **one** argument, such as `app.route('/api')`.
    * The use of `route` with **one** argument has been removed in v4.
@@ -162,7 +162,7 @@ class Hono<
   >(
     path: SubPath,
     app?: Hono<SubEnv, SubSchema, SubBasePath>
-  ): Hono<E, MergeSchemaPath<SubSchema, SubPath> & S, BasePath> {
+  ): Hono<E, MergeSchemaPath<SubSchema, MergePath<BasePath, SubPath>> & S, BasePath> {
     const subApp = this.basePath(path)
 
     if (!app) {

diff --git a/src/client/client.test.ts b/src/client/client.test.ts
@@ -339,6 +339,13 @@ describe('Merge path with `app.route()`', () => {
           ok: true,
         })
       )
+    }),
+    rest.get('http://localhost/v1/book', async (req, res, ctx) => {
+      return res(
+        ctx.json({
+          ok: true,
+        })
+      )
     })
   )
 
@@ -374,6 +381,17 @@ describe('Merge path with `app.route()`', () => {
     expect(data.ok).toBe(true)
   })
 
+  it('Should have correct types - basePath(), route(), get()', async () => {
+    const book = new Hono().get('/', (c) => c.jsonT({ ok: true }))
+    const app = new Hono().basePath('/v1').route('/book', book)
+    type AppType = typeof app
+    const client = hc<AppType>('http://localhost')
+    const res = await client.v1.book.index.$get()
+    const data = await res.json()
+    type verify = Expect<Equal<boolean, typeof data.ok>>
+    expect(data.ok).toBe(true)
+  })
+
   it('Should have correct types - with interface', async () => {
     interface Result {
       ok: boolean

diff --git a/src/hono-base.ts b/src/hono-base.ts
@@ -147,7 +147,7 @@ class Hono<
   >(
     path: SubPath,
     app: Hono<SubEnv, SubSchema, SubBasePath>
-  ): Hono<E, MergeSchemaPath<SubSchema, SubPath> & S, BasePath>
+  ): Hono<E, MergeSchemaPath<SubSchema, MergePath<BasePath, SubPath>> & S, BasePath>
   /** @description
    * Use `basePath` instead of `route` when passing **one** argument, such as `app.route('/api')`.
    * The use of `route` with **one** argument has been removed in v4.
@@ -162,7 +162,7 @@ class Hono<
   >(
     path: SubPath,
     app?: Hono<SubEnv, SubSchema, SubBasePath>
-  ): Hono<E, MergeSchemaPath<SubSchema, SubPath> & S, BasePath> {
+  ): Hono<E, MergeSchemaPath<SubSchema, MergePath<BasePath, SubPath>> & S, BasePath> {
     const subApp = this.basePath(path)
 
     if (!app) {