Skip to content

Commit

Permalink
[ROCm] Fix build problem resulted from previous commit related to FP8…
Browse files Browse the repository at this point in the history
… kv-cache support (vllm-project#2790)
  • Loading branch information
hongxiayang authored Feb 7, 2024
1 parent 769f13c commit dbdb467
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 0 deletions.
1 change: 1 addition & 0 deletions Dockerfile.rocm
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ RUN cd /app \
&& cd vllm \
&& pip install -U -r requirements-rocm.txt \
&& bash patch_xformers.rocm.sh \
&& patch /opt/rocm/include/hip/amd_detail/amd_hip_bf16.h /app/vllm/rocm_patch/rocm_bf16.patch \
&& python3 setup.py install \
&& cd ..

Expand Down
15 changes: 15 additions & 0 deletions rocm_patch/rocm_bf16.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
--- amd_hip_bf16.h 2024-02-06 18:28:58.268699142 +0000
+++ amd_hip_bf16.h.new 2024-02-06 18:28:31.988647133 +0000
@@ -90,10 +90,10 @@
#include "math_fwd.h" // ocml device functions

#if defined(__HIPCC_RTC__)
-#define __HOST_DEVICE__ __device__
+#define __HOST_DEVICE__ __device__ static
#else
#include <climits>
-#define __HOST_DEVICE__ __host__ __device__
+#define __HOST_DEVICE__ __host__ __device__ static inline
#endif

// Since we are using unsigned short to represent data in bfloat16, it can be of different sizes on

0 comments on commit dbdb467

Please sign in to comment.