Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): lint Dockerfile #2637

Merged
merged 2 commits into from
Jun 19, 2021
Merged

feat(app): lint Dockerfile #2637

merged 2 commits into from
Jun 19, 2021

Conversation

hongbo-miao
Copy link
Owner

@hongbo-miao hongbo-miao commented Jun 19, 2021

Close #2613

@hongbo-miao hongbo-miao self-assigned this Jun 19, 2021
@hongbo-miao hongbo-miao force-pushed the hadolint branch 2 times, most recently from a544a69 to 3bfed13 Compare June 19, 2021 21:00
@codecov
Copy link

codecov bot commented Jun 19, 2021

Codecov Report

Merging #2637 (5dc450d) into main (005419d) will increase coverage by 4.72%.
The diff coverage is 92.64%.

❗ Current head 5dc450d differs from pull request most recent head d6c3a9c. Consider uploading reports for the commit d6c3a9c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2637      +/-   ##
==========================================
+ Coverage   61.27%   66.00%   +4.72%     
==========================================
  Files          50       58       +8     
  Lines         297      350      +53     
  Branches       47       65      +18     
==========================================
+ Hits          182      231      +49     
- Misses        113      118       +5     
+ Partials        2        1       -1     
Impacted Files Coverage Δ
api/src/log/utils/logger.ts 66.66% <ø> (ø)
api/src/reliability/utils/createCircuitBreaker.ts 100.00% <ø> (ø)
web/src/App/fixtures/WEBSITES.ts 100.00% <ø> (ø)
web/src/Home/reducers/meReducer.ts 100.00% <ø> (+14.28%) ⬆️
web/src/health/actions/HealthAction.ts 100.00% <ø> (ø)
web/src/health/epics/pingEpic.ts 0.00% <0.00%> (ø)
web/src/health/reducers/healthReducer.ts 0.00% <ø> (ø)
web/src/index.tsx 0.00% <ø> (ø)
web/src/shared/utils/graphQLFetch.ts 0.00% <0.00%> (ø)
web/src/shared/utils/initTracer.ts 0.00% <0.00%> (ø)
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e485883...d6c3a9c. Read the comment docs.

@codeclimate
Copy link

codeclimate bot commented Jun 19, 2021

Code Climate has analyzed commit d6c3a9c and detected 0 issues on this pull request.

View more on Code Climate.

@hongbo-miao hongbo-miao merged commit 867cd52 into main Jun 19, 2021
@hongbo-miao hongbo-miao deleted the hadolint branch June 19, 2021 21:08
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint Dockerfile
1 participant