Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(r/burn_alert): handle existing remote description with default description value #575

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

jharley
Copy link
Collaborator

@jharley jharley commented Nov 15, 2024

When upgrading to 0.28.0, if you have an existing burn alert that had a description set (via the UI, most likely) but the description was yet to be added to HCL config you will get the following error:

Error: Provider produced inconsistent result after apply
        
        When applying changes to honeycombio_burn_alert.test, provider
        "provider[\"registry.terraform.io/hashicorp/honeycombio\"]" produced an
        unexpected new value: .description: was cty.StringVal(""), but now
        cty.StringVal("test description").

Fix is to ensure we send the empty string when we marshal our JSON

@jharley jharley added the bug label Nov 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.55%. Comparing base (c8084fc) to head (c69c49c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #575   +/-   ##
=======================================
  Coverage   75.55%   75.55%           
=======================================
  Files          87       87           
  Lines        7286     7286           
=======================================
  Hits         5505     5505           
  Misses       1429     1429           
  Partials      352      352           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jharley jharley marked this pull request as ready for review November 15, 2024 20:18
@jharley jharley requested a review from a team as a code owner November 15, 2024 20:18
@jharley jharley merged commit 292bbb2 into main Nov 15, 2024
6 checks passed
@jharley jharley deleted the jharley.fix-burn-alert-description branch November 15, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants