Add support for environments #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGoldsmith
approved these changes
Apr 6, 2022
src/libhoney.js
Outdated
| if (typeof dataset !== "string" || dataset === "") { | ||
| console.error(".dataset must be a non-empty string"); | ||
| if (typeof dataset !== "string") { | ||
| console.error(".dataset must be a string"); |
There was a problem hiding this comment.
Suggested change
| console.error(".dataset must be a string"); | |
| console.error("dataset must be a string"); |
src/libhoney.js
Outdated
| return null; | ||
| } | ||
|
|
||
| if (dataset === "") { | ||
| if (this.isClassic(writeKey)) { | ||
| console.error(".dataset must be a non-empty string"); |
There was a problem hiding this comment.
Suggested change
| console.error(".dataset must be a non-empty string"); | |
| console.error("dataset must be a non-empty string"); |
src/__tests__/libhoney_test.js
Outdated
|
|
||
| expect(transmission.events).toHaveLength(0); | ||
| expect(console.error.mock.calls[0][0]).toBe( | ||
| ".dataset must be a non-empty string" |
There was a problem hiding this comment.
Suggested change
| ".dataset must be a non-empty string" | |
| "dataset must be a non-empty string" |
MikeGoldsmith
approved these changes
Apr 7, 2022
kentquirk
changed the title
Merged
kentquirk
added a commit
that referenced
this pull request
Apr 7, 2022
Release PR for 3.1.0 ### Enhancements - Add support for environments (#244) | [@kentquirk](https://github.com/kentquirk) - ci: add node 17 to test matrix (#195) | [@vreynolds](https://github.com/vreynolds) - empower apply-labels action to apply labels (#205) | [@robbkidd](https://github.com/robbkidd) ### Maintenance - gh: add re-triage workflow (#215) | [@vreynolds](https://github.com/vreynolds) - Update dependabot.yml (#212) | [@vreynolds](https://github.com/vreynolds) - Remove husky and lint-staged - Bump @babel/core to 7.16.12 (#230) - Bump @babel/eslint-parser to 7.16.5 (#223) - Bump @babel/preset-env to 7.16.8 (#224) - Bump @rollup/plugin-commonjs to 21.0.1 (#197) - Bump @rollup/plugin-node-resolve to 13.1.3 (#225) - Bump @rollup/plugin-replace to 3.0.1 (#216) - Bump eslint to 8.6.0 (#227) - Bump minimist to 2.5.1 (#220) - Bump superagent from 6.1.0 to 7.0.2 (#226) - Bump vm2 to 3.9.7 (#234)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Closes #238
Short description of the changes