Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update README with details on SDK builder overwriting issue #351

Merged
merged 1 commit into from
May 11, 2023

Conversation

MikeGoldsmith
Copy link
Contributor

Which problem is this PR solving?

Updates the readme with details on the OpenTelemetry SDKs builder pattern and how it can lead to options set by the distro to be overridden.

Short description of the changes

Update README with OTel SDK builder pattern

@MikeGoldsmith MikeGoldsmith added type: documentation Improvements or additions to documentation version: no bump A PR with maintenance or doc changes that aren't included in a release. labels May 10, 2023
@MikeGoldsmith MikeGoldsmith self-assigned this May 10, 2023
@MikeGoldsmith MikeGoldsmith requested a review from a team May 10, 2023 11:43
@MikeGoldsmith MikeGoldsmith changed the title [docs] Update README with details on SDK builder overwriting issue docs: Update README with details on SDK builder overwriting issue May 10, 2023
@MikeGoldsmith MikeGoldsmith merged commit 42e4864 into main May 11, 2023
@MikeGoldsmith MikeGoldsmith deleted the mike/doc-sampler branch May 11, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation Improvements or additions to documentation version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding provider resets sampler
2 participants