maint: Rename AutoInstrumentations package #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGoldsmith
added
the
type: maintenance
cartermp
reviewed
Nov 30, 2022
|
Yeah, docs will need to be updated too. That can be done once we release this new package. |
cartermp
approved these changes
Dec 1, 2022
MikeGoldsmith
added
version: bump minor
|
waiting to bump upstream OTel before releasing this |
This was referenced Feb 27, 2023
Closed
JamieDanielson
added a commit
that referenced
this pull request
Mar 3, 2023
## Which problem is this PR solving? - release of new main package, including dependency updates and method changes from OTel v1.4.0 - release of new instrumentation package, including name change ## Short description of the changes - add changelog entries. - We renamed `AutoInstrumentations` to `CommonInstrumentations`; see #327 for more details. - OTel changed to `AddOpenTelemetry().WithTracing` and `AddOpenTelemetry().WithMetrics`; see #334 for more details. - Update versions of main package from 1.2.1 to 1.3.0 - Update versions of instrumentation packages from 0.26.1-beta to 0.27.0-beta - Update releasing notes with extra details for clarity Once the release is out, docs updates can be merged in for public docs and in-app onboarding (see #339 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
The AutoInstrumentations package doesn't accurately describe what the package actually does. It wires up some common instrumentation packages automatically for you, it does not have anything to do with auto instrumentation.
This PR renames the package to be more clear on what it does.
Short description of the changes