Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Fix nightly build #294

Merged
merged 1 commit into from
Oct 7, 2022
Merged

[ci] Fix nightly build #294

merged 1 commit into from
Oct 7, 2022

Conversation

pkanal
Copy link
Contributor

@pkanal pkanal commented Oct 7, 2022

Which problem is this PR solving?

The nightly build is currently failing because the package job requires secrets. This PR removes the package job from the nightly build since we don't actually need to create the package to run tests or smoke tests. This change is something that was discussed as we were building the distro but we decided to tackle it later. Since it solves our nightly build problem, we should remove that job from the workflow now.

Short description of the changes

  • Removes the package step from the nightly workflow

@pkanal pkanal changed the title remove package step from nightly workflow [ci] Fix nightly build Oct 7, 2022
@pkanal pkanal marked this pull request as ready for review October 7, 2022 16:06
@pkanal pkanal requested review from a team and robbkidd October 7, 2022 16:06
@pkanal pkanal self-assigned this Oct 7, 2022
@pkanal pkanal added type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release. labels Oct 7, 2022
vreynolds
vreynolds approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@vreynolds vreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❇️

@pkanal pkanal merged commit aa431e8 into main Oct 7, 2022
@pkanal pkanal deleted the purvi/fix-nightly-build branch October 7, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vreynolds vreynolds vreynolds approved these changes

@robbkidd robbkidd Awaiting requested review from robbkidd

Assignees

@pkanal pkanal

Labels
type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

circleci nightly workflow not building properly
2 participants
@pkanal @vreynolds