Remove custom command line argument parsing #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGoldsmith
added
the
type: maintenance
cartermp
approved these changes
Sep 27, 2022
There was a problem hiding this comment.
Chatted with @MikeGoldsmith about this - this was always sort of a nice-to-have since it's not a common way for people to configure apps in the first place. The fact that it's not a common path, and can clobber your config means it's probably not worth keeping around.
JamieDanielson
added
the
version: bump minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Command line argument parsing is an underused feature and conflicts with conventional ConfigurationManager based config (eg appsettings). This PR removes command line arg parsing, which simplifies the distro by a good amount.
Short description of the changes