Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ConfigurationManager extension methods #280

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Add ConfigurationManager extension methods #280

merged 1 commit into from
Sep 27, 2022

Conversation

MikeGoldsmith
Copy link
Contributor

Which problem is this PR solving?

Adds extension methods for ConfigurationBuilder to help making getting options from appsettings.json.

Short description of the changes

  • Adds ConfigurationBuilder extension method
  • Update aspnetcore examples to use new ext method

@MikeGoldsmith MikeGoldsmith added the type: enhancement New feature or request label Sep 27, 2022
@MikeGoldsmith MikeGoldsmith self-assigned this Sep 27, 2022
@MikeGoldsmith MikeGoldsmith requested review from a team and emilyashley September 27, 2022 15:48
@MikeGoldsmith MikeGoldsmith changed the title Add ConfigurationManager extensions methods Add ConfigurationManager extension methods Sep 27, 2022
cartermp
cartermp approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change!

@MikeGoldsmith MikeGoldsmith merged commit 127a8d6 into main Sep 27, 2022
@MikeGoldsmith MikeGoldsmith deleted the mike/configbuilder-ext branch September 27, 2022 16:05
@MikeGoldsmith MikeGoldsmith added this to the GA Release milestone Sep 27, 2022
@JamieDanielson JamieDanielson added the version: bump minor A PR that adds behavior, but is backwards-compatible. label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermp cartermp cartermp approved these changes

@emilyashley emilyashley Awaiting requested review from emilyashley

Assignees

@MikeGoldsmith MikeGoldsmith

Labels
type: enhancement New feature or request version: bump minor A PR that adds behavior, but is backwards-compatible.
Projects
None yet
Milestone
GA Release
Development

Successfully merging this pull request may close these issues.
3 participants
@MikeGoldsmith @cartermp @JamieDanielson