Move extensions into owning class namespace & rename add instrumentations ext method #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGoldsmith
added
type: enhancement
MikeGoldsmith
commented
Sep 26, 2022
| @@ -111,7 +110,7 @@ private static ResourceBuilder AddOSResource(this ResourceBuilder builder) | |||
|
|
|||
| private static string GetFileVersion() | |||
| { | |||
| var version = typeof(ResourceBuilderExtensions) | |||
There was a problem hiding this comment.
Using a class in another namespace to find this library can lead to conflicts so we're using a class that's in the Honeycomb.OpenTelemetry namespace.
|
FYI build and unit tests are passing, smoke tests are failing in CI. I've opened #277 to track. |
MikeGoldsmith
changed the title
cartermp
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
When providing extensions for classes in other libraries, the expectation is to use the same namespace as this doesn't require consumers to add extra imports.
This PR updates all extension classes to use the same namespace as the class that's being extended. eg TracerProviderBuilder is now in OpenTelemetry.Trace.
It also renames
AddAllInstrumentationtoAddAutoInstrumentationswhich is a clearer function name and can't be insinuated that we it will add all possible instrumentation packages instead of ones we've selected.Short description of the changes
AddAllInstrumentationtoAddAutoInstrumentations