Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make targets for smoke tests & set up CI smoke tests #268

Merged
merged 8 commits into from
Sep 23, 2022

Conversation

pkanal
Copy link
Contributor

@pkanal pkanal commented Sep 22, 2022

Which problem is this PR solving?

Adds make targets for smoke tests and run them in CI.

Short description of the changes

Makefile Changes

  • smoke-tests/collector/data.json makes sure there is always a data.json file in the collector folder so that tests can run reliably
  • smoke-sdk-grpc runs bats tests for smoke tests over gRPC
  • smoke-sdk-http runs bats tests for smoke tests over http/protobuf
  • smoke-sdk runs bats tests for all sdk tests
  • smoke runs all bats smoke tests
  • unsmoke tears down setup for smoke tests
  • resmoke tears down and then runs smoke tests

CI Changes

  • added bats 1.0 orb and installed 1.0 bats during smoke-tests job
  • stored test results so that CI test tab is populated correctly
  • stored artifacts for test results and JSON files with traces

How to test

Local Makefile

  1. Fetch and checkout this branch
  2. Test the new commands by running make <command>
  3. Locally, it is important to unsmoke after running a set of tests, you can get into a weird state if you run clean without unsmoke.

CI

@pkanal pkanal force-pushed the purvi/makefile-smoke-tests branch from 6239191 to 916e089 Compare September 22, 2022 16:51
@pkanal pkanal changed the title Add make targets for smoke tests Add make targets for smoke tests & set up CI smoke tests Sep 22, 2022
@pkanal pkanal marked this pull request as ready for review September 22, 2022 16:58
@pkanal pkanal requested review from a team and kentquirk September 22, 2022 16:58
@pkanal pkanal self-assigned this Sep 22, 2022
@pkanal pkanal added the type: maintenance The necessary chores to keep the dust off. label Sep 22, 2022
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks @pkanal 👍🏻

@pkanal pkanal merged commit 9f53581 into main Sep 23, 2022
@pkanal pkanal deleted the purvi/makefile-smoke-tests branch September 23, 2022 15:35
@JamieDanielson JamieDanielson added the version: no bump A PR with maintenance or doc changes that aren't included in a release. label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[smoke tests] run smoke tests in CI [smoke tests] create make targets for smoke tests
3 participants