-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support debug option #254
Support debug option #254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @cartermp 👍🏻
Needs a rebase, but should be good to go 👍🏻 |
1853e7c
to
4974e72
Compare
@MikeGoldsmith should be good to go now! |
<PackageReference Include="OpenTelemetry" Version="1.3.1" /> | ||
<PackageReference Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" Version="1.3.1" /> | ||
<PackageReference Include="OpenTelemetry.Exporter.Console" Version="1.3.1" /> | ||
<PackageReference Include="OpenTelemetry.Instrumentation.Http" Version="1.0.0-rc9.4" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want to be re-add instrumentation packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, whoopsie
DEBUG
option #253Note that because of #46, this is harder to test out in various ways. But here's an example of using it from code:
And the corresponding trace/metric is in the