Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support debug option #254

Merged
merged 4 commits into from
Sep 20, 2022
Merged

Support debug option #254

merged 4 commits into from
Sep 20, 2022

Conversation

cartermp
Copy link
Member

@cartermp cartermp commented Sep 20, 2022

Note that because of #46, this is harder to test out in various ways. But here's an example of using it from code:

λ ~/repos/honeycomb-opentelemetry-dotnet/ cartermp/debug* dotnet run --project examples/console
Resource associated with Metric:
    service.name: phillips-happy-fun-time
    service.version: {unknown_service_version}
    service.instance.id: 700ca5d0-1b13-4b10-94b4-e2ecd6552499
    os.type: darwin
    os.description: Unix 12.5.1
    os.name: macOS
    os.version: 12.5.1
    process.runtime.name: .NET
    process.runtime.version:  6.0.8
    honeycomb.distro.language: dotnet
    honeycomb.distro.version: 0.23.0-beta
    honeycomb.distro.runtime_version: 6.0.8

Export sheep, Meter: phillips-happy-fun-time
(2022-09-20T00:43:53.5647680Z, 2022-09-20T00:43:54.0341820Z] LongSum
Value: 1
Activity.TraceId:          e43694bacee8508c4b777c607b3316bf
Activity.SpanId:           f2d7263e925a39a1
Activity.TraceFlags:           Recorded
Activity.ActivitySourceName: phillips-happy-fun-time
Activity.DisplayName: doSomething
Activity.Kind:        Internal
Activity.StartTime:   2022-09-20T00:43:53.5489160Z
Activity.Duration:    00:00:00.4930540
Activity.Tags:
    SampleRate: 1
    user_id: 123
Resource associated with Activity:
    service.name: phillips-happy-fun-time
    service.version: {unknown_service_version}
    service.instance.id: 06dd9176-f417-4511-8dbf-7e72f6c624a4
    os.type: darwin
    os.description: Unix 12.5.1
    os.name: macOS
    os.version: 12.5.1
    process.runtime.name: .NET
    process.runtime.version:  6.0.8
    honeycomb.distro.language: dotnet
    honeycomb.distro.version: 0.23.0-beta
    honeycomb.distro.runtime_version: 6.0.8
    my-attribute: some-value

And the corresponding trace/metric is in the

@cartermp cartermp requested review from a team and pkanal September 20, 2022 00:45
@MikeGoldsmith MikeGoldsmith added type: enhancement New feature or request version: bump minor A PR that adds behavior, but is backwards-compatible. labels Sep 20, 2022
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @cartermp 👍🏻

@MikeGoldsmith
Copy link
Contributor

Needs a rebase, but should be good to go 👍🏻

@MikeGoldsmith MikeGoldsmith added the status: revision needed Waiting for response to changes requested. label Sep 20, 2022
@cartermp
Copy link
Member Author

@MikeGoldsmith should be good to go now!

<PackageReference Include="OpenTelemetry" Version="1.3.1" />
<PackageReference Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" Version="1.3.1" />
<PackageReference Include="OpenTelemetry.Exporter.Console" Version="1.3.1" />
<PackageReference Include="OpenTelemetry.Instrumentation.Http" Version="1.0.0-rc9.4" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to be re-add instrumentation packages.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, whoopsie

@MikeGoldsmith MikeGoldsmith merged commit 0d069fe into main Sep 20, 2022
@MikeGoldsmith MikeGoldsmith deleted the cartermp/debug branch September 20, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: revision needed Waiting for response to changes requested. type: enhancement New feature or request version: bump minor A PR that adds behavior, but is backwards-compatible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support DEBUG option Update OTel packages to GA releases
2 participants