Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blazor-wasm example #251

Closed
wants to merge 4 commits into from
Closed

Add blazor-wasm example #251

wants to merge 4 commits into from

Conversation

MikeGoldsmith
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith commented Sep 15, 2022 •
edited
Loading

Which problem is this PR solving?

Adds a simple blazor wasm app that uses Honeycomb distro to configure itself.

Short description of the changes

  • adds new blazor wasm example

@MikeGoldsmith MikeGoldsmith added type: enhancement New feature or request version: bump minor A PR that adds behavior, but is backwards-compatible. labels Sep 15, 2022
@MikeGoldsmith MikeGoldsmith requested a review from a team September 15, 2022 12:43
@MikeGoldsmith MikeGoldsmith self-assigned this Sep 15, 2022
@MikeGoldsmith MikeGoldsmith requested review from pkanal and removed request for a team September 15, 2022 12:43
Base automatically changed from mike/reorganise-packages to main September 20, 2022 09:45
@MikeGoldsmith MikeGoldsmith added the status: revision needed Waiting for response to changes requested. label Sep 20, 2022
@cartermp cartermp mentioned this pull request Sep 20, 2022
Open
@MikeGoldsmith MikeGoldsmith removed the status: revision needed Waiting for response to changes requested. label Sep 21, 2022
@MikeGoldsmith MikeGoldsmith changed the title Add Blazor example Add blazor-wasm example Sep 21, 2022
pkanal
pkanal requested changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@pkanal pkanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the app looks solid to me! I tried running it an ran into the error in the screenshot below, I tried adding Honeycomb options to the launchSettings.json file and still got an error. Could we add some instructions for how to run the app?
Screen Shot 2022-09-21 at 10 59 14 AM

@MikeGoldsmith
Copy link
Contributor Author

MikeGoldsmith commented Sep 21, 2022 •
edited
Loading

Yep, I saw the same error and working on making it work better 😄 I'll move to draft for now

@MikeGoldsmith MikeGoldsmith marked this pull request as draft September 21, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkanal pkanal pkanal requested changes

Assignees

@MikeGoldsmith MikeGoldsmith

Labels
type: enhancement New feature or request version: bump minor A PR that adds behavior, but is backwards-compatible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikeGoldsmith @pkanal