Attempt to match Java distro resources #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGoldsmith
requested changes
Sep 15, 2022
| private static ResourceBuilder AddRuntimeResource(this ResourceBuilder builder) | ||
| { | ||
| var frameworkDescription = RuntimeInformation.FrameworkDescription; | ||
| var parts = frameworkDescription.Split(' '); |
There was a problem hiding this comment.
I think it's wise to test we have the correct number of parts or we risk a invalid index runtime exception.
There was a problem hiding this comment.
Yeah, actually it's a bit more complicated than this because of .NET Core and .NET Framework. So what we're really after is a rudimentary parser. I'll do that.
MikeGoldsmith
added
type: enhancement
MikeGoldsmith
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this gets us as close as we can with #119 given the following constraints:
That said, I think it's valuable to have something rather than nothing.