Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .NET 6 minimal API example #139

Closed
wants to merge 6 commits into from
Closed

Conversation

cartermp
Copy link
Member

@cartermp cartermp commented Nov 9, 2021

Fixes #134

@cartermp cartermp requested a review from a team November 9, 2021 02:37
@cartermp
Copy link
Member Author

cartermp commented Nov 9, 2021

Argh, I don't think circleCI has an up to date .NET image :(

Creating a dedicated VM with windows-server-2019-vs2019:stable image

Since it relies on visual studio-based images rather than just pulling in the .NET docker image, it might be more complicated to support .NET 6 in this repo

@bdarfler
Copy link
Contributor

@cartermp maybe we need a custom docker image? https://circleci.com/docs/2.0/custom-images/

@bdarfler bdarfler marked this pull request as draft November 15, 2021 20:14
@bdarfler bdarfler added the status: revision needed Waiting for response to changes requested. label Jan 29, 2022
@github-actions
Copy link

github-actions bot commented Mar 1, 2022

Marking this PR as stale because it has been open 30 days with no activity. Please add a comment if this PR is still relevant; otherwise this PR will be automatically closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 1, 2022
@cartermp
Copy link
Member Author

cartermp commented Mar 1, 2022

will probably do this later, circle is still taking their time

@cartermp cartermp closed this Mar 1, 2022
@cartermp cartermp reopened this Apr 18, 2022
@cartermp
Copy link
Member Author

whelp https://discuss.circleci.com/t/cant-see-to-find-an-orb-with-support-for-dotnet-6/42652/4

Looks like Circle still haven't updated any orbs to support .NET 6, the LTS that's been out since November 2021.

Contemplating using the workaround posted in the form like there so we have samples using the LTS release when we go GA.

@cartermp cartermp closed this Apr 18, 2022
@MikeGoldsmith MikeGoldsmith deleted the phillip.add-dotnet6-sample branch September 21, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale status: revision needed Waiting for response to changes requested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add/update samples and update docs to coincide with .NET 6
2 participants