Skip to content

Commit

Permalink
maint: Update OpenTelemetry instrumentation packages (#334)
Browse files Browse the repository at this point in the history
## Which problem is this PR solving?
Bumps OpenTelemetry instrumentation packages to latest.

## Short description of the changes
- Bump instrumentation pacakages to latest

---------

Co-authored-by: cartermp <[email protected]>
  • Loading branch information
MikeGoldsmith and cartermp authored Mar 1, 2023
1 parent 2f89cba commit 704e234
Show file tree
Hide file tree
Showing 9 changed files with 31 additions and 28 deletions.
7 changes: 5 additions & 2 deletions examples/aspnetcore-fsharp/Program.fs
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ open Microsoft.Extensions.Configuration

open Giraffe
open Giraffe.EndpointRouting

open OpenTelemetry
open OpenTelemetry.Trace
open OpenTelemetry.Metrics
open Honeycomb.OpenTelemetry
Expand All @@ -17,12 +19,13 @@ let configureServices (services: IServiceCollection) (honeycombOptions: Honeycom
services
.AddRouting()
.AddGiraffe()
.AddOpenTelemetryTracing(fun otelBuilder ->
.AddOpenTelemetry()
.WithTracing(fun otelBuilder ->
otelBuilder
.AddHoneycomb(honeycombOptions)
.AddAspNetCoreInstrumentationWithBaggage()
|> ignore)
.AddOpenTelemetryMetrics(fun otelBuilder ->
.WithMetrics(fun otelBuilder ->
otelBuilder.AddHoneycomb(honeycombOptions)
|> ignore)
|> ignore
Expand Down
2 changes: 1 addition & 1 deletion examples/aspnetcore-fsharp/aspnetcore-fsharp.fsproj
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

<ItemGroup>
<PackageReference Include="Giraffe" Version="6.0.0" />
<PackageReference Include="OpenTelemetry.Extensions.Hosting" Version="1.0.0-rc9.9" />
<PackageReference Include="OpenTelemetry.Extensions.Hosting" Version="1.4.0" />
</ItemGroup>

<ItemGroup>
Expand Down
4 changes: 2 additions & 2 deletions examples/aspnetcore-redis/Program.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@

var honeycombOptions = builder.Configuration.GetHoneycombOptions();

builder.Services.AddOpenTelemetryTracing(otelBuilder =>
builder.Services.AddOpenTelemetry().WithTracing(otelBuilder =>
otelBuilder
.AddHoneycomb(builder.Configuration)
.AddHoneycomb(honeycombOptions)
.AddAspNetCoreInstrumentationWithBaggage()
.AddRedisInstrumentation(redis)
);
Expand Down
2 changes: 1 addition & 1 deletion examples/aspnetcore-redis/aspnetcoreredis.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="OpenTelemetry.Extensions.Hosting" Version="1.0.0-rc9.9" />
<PackageReference Include="OpenTelemetry.Extensions.Hosting" Version="1.4.0" />
<PackageReference Include="OpenTelemetry.Instrumentation.StackExchangeRedis" Version="1.0.0-rc9.7" />
</ItemGroup>

Expand Down
5 changes: 3 additions & 2 deletions examples/aspnetcore/Program.cs
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
using OpenTelemetry.Metrics;
using OpenTelemetry.Trace;

using System.Diagnostics.Metrics;

var builder = WebApplication.CreateBuilder(args);
Expand All @@ -8,7 +9,7 @@
var honeycombOptions = builder.Configuration.GetHoneycombOptions();

// Setup OpenTelemetry Tracing
builder.Services.AddOpenTelemetryTracing(otelBuilder =>
builder.Services.AddOpenTelemetry().WithTracing(otelBuilder =>
otelBuilder
.AddHoneycomb(honeycombOptions)
.AddAspNetCoreInstrumentationWithBaggage()
Expand All @@ -18,7 +19,7 @@
builder.Services.AddSingleton(TracerProvider.Default.GetTracer(honeycombOptions.ServiceName));

// Setup OpenTelemetry Metrics
builder.Services.AddOpenTelemetryMetrics(otelBuilder =>
builder.Services.AddOpenTelemetry().WithMetrics(otelBuilder =>
otelBuilder.AddHoneycomb(honeycombOptions)
);

Expand Down
2 changes: 1 addition & 1 deletion examples/aspnetcore/aspnetcore.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="OpenTelemetry.Extensions.Hosting" Version="1.0.0-rc9.9" />
<PackageReference Include="OpenTelemetry.Extensions.Hosting" Version="1.4.0" />
</ItemGroup>

</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -26,31 +26,30 @@
<RepositoryType>git</RepositoryType>
</PropertyGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'net6.0' ">
<ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETCoreApp' And
$([MSBuild]::VersionGreaterThanOrEquals($(_TargetFrameworkVersionWithoutV), '6.0'))">
<ProjectReference Include="..\Honeycomb.OpenTelemetry.Instrumentation.AspNetCore\Honeycomb.OpenTelemetry.Instrumentation.AspNetCore.csproj" />
</ItemGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'net462' ">
<PackageReference Include="OpenTelemetry.Instrumentation.Owin" Version="1.0.0-rc.3" />
<PackageReference Include="OpenTelemetry.Instrumentation.AspNet" Version="1.0.0-rc9.6" />
<PackageReference Include="OpenTelemetry.Instrumentation.AspNet" Version="1.0.0-rc9.8" />
</ItemGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'net6.0' ">
<PackageReference Include="OpenTelemetry.Instrumentation.GrpcNetClient" Version="1.0.0-rc9.9" />
</ItemGroup>

<ItemGroup Condition=" '$(TargetFramework)' != 'net462' ">
<PackageReference Include="OpenTelemetry.Instrumentation.Quartz" Version="1.0.0-alpha.1" />
<ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETCoreApp' And
$([MSBuild]::VersionGreaterThanOrEquals($(_TargetFrameworkVersionWithoutV), '6.0'))">
<PackageReference Include="OpenTelemetry.Instrumentation.GrpcNetClient" Version="1.0.0-rc9.14" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="Npgsql.OpenTelemetry" Version="6.0.7" />
<PackageReference Include="OpenTelemetry.Instrumentation.EntityFrameworkCore" Version="1.0.0-beta.3" />
<PackageReference Include="OpenTelemetry.Instrumentation.Http" Version="1.0.0-rc9.9" />
<PackageReference Include="OpenTelemetry.Instrumentation.MySqlData" Version="1.0.0-beta.4" />
<PackageReference Include="OpenTelemetry.Instrumentation.SqlClient" Version="1.0.0-rc9.9" />
<PackageReference Include="OpenTelemetry.Instrumentation.StackExchangeRedis" Version="1.0.0-rc9.7" />
<PackageReference Include="OpenTelemetry.Instrumentation.Wcf" Version="1.0.0-rc.7" />
<PackageReference Include="Npgsql.OpenTelemetry" Version="7.0.2" />
<PackageReference Include="OpenTelemetry.Instrumentation.EntityFrameworkCore" Version="1.0.0-beta.5" />
<PackageReference Include="OpenTelemetry.Instrumentation.Http" Version="1.0.0-rc9.14" />
<PackageReference Include="OpenTelemetry.Instrumentation.MySqlData" Version="1.0.0-beta.6" />
<PackageReference Include="OpenTelemetry.Instrumentation.SqlClient" Version="1.0.0-rc9.14" />
<PackageReference Include="OpenTelemetry.Instrumentation.StackExchangeRedis" Version="1.0.0-rc9.8" />
<PackageReference Include="OpenTelemetry.Instrumentation.Wcf" Version="1.0.0-rc.9" />
<PackageReference Include="OpenTelemetry.Instrumentation.Quartz" Version="1.0.0-alpha.2" />
</ItemGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="OpenTelemetry.Instrumentation.AspNetCore" Version="1.0.0-rc9.9" />
<PackageReference Include="OpenTelemetry.Instrumentation.AspNetCore" Version="1.0.0-rc9.14" />
</ItemGroup>

<ItemGroup>
Expand Down
6 changes: 3 additions & 3 deletions src/Honeycomb.OpenTelemetry/Honeycomb.OpenTelemetry.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="OpenTelemetry" Version="1.3.1" />
<PackageReference Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" Version="1.3.1" />
<PackageReference Include="OpenTelemetry.Exporter.Console" Version="1.3.1" />
<PackageReference Include="OpenTelemetry" Version="1.4.0" />
<PackageReference Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" Version="1.4.0" />
<PackageReference Include="OpenTelemetry.Exporter.Console" Version="1.4.0" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="All" />
<PackageReference Include="Microsoft.Extensions.Configuration.CommandLine" Version="6.0.0" />
<PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="6.0.0" />
Expand Down

0 comments on commit 704e234

Please sign in to comment.