Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The sample rate on the event is not forwarded #145

Closed
cursedquail opened this issue Oct 30, 2024 · 0 comments · Fixed by #146
Closed

The sample rate on the event is not forwarded #145

cursedquail opened this issue Oct 30, 2024 · 0 comments · Fixed by #146
Labels
status: oncall Flagged for awareness from Honeycomb Telemetry Oncall type: bug Something isn't working

Comments

@cursedquail
Copy link
Contributor

Versions

Lambda runtime: al2023, arm64
Lambda extension: 11.2.3

Steps to reproduce

  1. Set SampleRate to, say, 5 in an app
  2. Deploy it
  3. The events are properly sampled, but by the time they make it to honeycomb there is no sample rate, so the aggregates are wrong.

Additional context

I think the issue is in here

honeycomb-lambda-extension/logsapi/server.go

Line 94 in 3519812

}

We're properly parsing the timestamp and the data, but we've neglected to copy the sample rate
@cursedquail cursedquail added the type: bug Something isn't working label Oct 30, 2024
cursedquail added a commit that referenced this issue Oct 30, 2024
@cursedquail
fix: forward the sample rate from the message
bd463a9 
If the app that we're forwarding telemetry for is doing it's own
sampling, we want to honor that

Closes #145
@cursedquail cursedquail mentioned this issue Oct 30, 2024
Merged
@TylerHelmuth TylerHelmuth added the status: oncall Flagged for awareness from Honeycomb Telemetry Oncall label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: oncall Flagged for awareness from Honeycomb Telemetry Oncall type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: forward the sample rate from the message honeycombio/honeycomb-lambda-extension
2 participants
@cursedquail @TylerHelmuth