Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow throughput samplers to have non-integer rates #74

Merged
merged 2 commits into from
Jan 12, 2024
Merged

fix: allow throughput samplers to have non-integer rates #74

merged 2 commits into from
Jan 12, 2024

Conversation

kentquirk
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • @yizzlez still gets credit for the fix

@kentquirk kentquirk requested a review from a team as a code owner January 12, 2024 03:18
This was referenced Jan 12, 2024
Closed
Merged
@kentquirk
Copy link
Contributor Author

Thanks, @TylerHelmuth -- turns out this is gonna require some tweaks to tests. I'll tackle it in the morning.

@fchikwekwe
Copy link
Contributor

Am I wrong in thinking that since the math is different here, the tests results just need to change?

@fchikwekwe
Copy link
Contributor

I've added a commit updating the test results. Hopefully this passes CI now.

@kentquirk kentquirk merged commit 404f948 into main Jan 12, 2024
3 checks passed
@kentquirk kentquirk deleted the windowed_tweak branch January 12, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchikwekwe fchikwekwe fchikwekwe approved these changes

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kentquirk @fchikwekwe @TylerHelmuth