Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This is re: #45 (comment)
The original code has a rare race condition:
currentIndex
is loadedcurrentIndex
is incrementedIncrementKey
is called on the updated indexAggregateCounts
is called on an oldcurrentIndex
. This is undefined behavior, ascurrentIndex
is assumed to be monotonically increasing.To validate that this race condition was fixed, I wrote a script that ran the test 100 times.
With the previous code, I observed 7 failures out of 100 runs.
With the new code, I observed 0 failures out of 100 runs.
Short description of the changes
Small change to unit tests.