Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC: fix PHP 7.2 compatibility #30

Closed
graste opened this issue Nov 23, 2017 · 4 comments
Closed

BC: fix PHP 7.2 compatibility #30

graste opened this issue Nov 23, 2017 · 4 comments
Assignees
@graste

Comments

@graste
Copy link
Member

graste commented Nov 23, 2017 

PHP Fatal error:  Cannot use Trellis\Common\Object as Object because 'Object' is a special class name in…

We can't use Object as a class name anymore. Was to be expected since some time and now we can't skip this change any longer. I suggest we think about whether we simply rename the class and then in a second step check whether there are classes that don't need to extend Object anymore.
@Pictor13
Copy link
Member

Pictor13 commented Nov 23, 2017 •
edited
Loading

What about the new name?

DataObject?
BaseObject?
DataSet?
Thing?
StateHolder? (brrrhh 😖)
Arrayable / Dumpable / Serializable (according to its interface method)
... other?

@graste
Copy link
Member Author

graste commented Nov 26, 2017 •
edited
Loading

Maybe rename to BaseObject and then remove it as an extended class where possible... What would @shrink0r do?

@graste graste self-assigned this Jan 30, 2018
@graste
Copy link
Member Author

graste commented Jan 30, 2018 •
edited
Loading

meh, forgot to reference this ticket in commit rev b2a4107

[master b2a4107] BC break: rename Object to BaseObject for PHP 7.2

Reminder to self: don't try to fix php7.2 compatibility on localhost w/ the php version not being 7.2. 🥇

graste added a commit that referenced this issue Jan 30, 2018
@graste
fix deprecated constant in default idn_to_ascii
46efa5a 
INTL_IDNA_VARIANT_2003 is deprecated and according to docs one should use
the constant INTL_IDNA_VARIANT_UTS46 now. As that seems to be supported
since php 5.4 we'll use it. Tests still green with that locally. refs #30
graste added a commit that referenced this issue Jan 30, 2018
@graste
bump deps, coveralls chg, use expectException
262d2b5 
Use expectException as phpunit 6 removed setExpectedException method
after it had been declared deprecated before.

bumping deps lead to coveralls not having the binary for coverage report
sending on travisci run anymore, thus I changed that to wget the binary
instead on CI and removed the dev-dependency to coveralls from composer.

refs #30
graste added a commit that referenced this issue Jan 30, 2018
@graste
adjust travisci build matrix and dependencies
2c12b3c 
- mockery and phpunit compatibility is weird and after looking in their
  travisci config I lowered the phpunit requirements for the prefer-lowest
  deps build for php 5.6 to phpunit ^5.4
- removed general php builds and the matrix is now specific which
  composer update deps are used for each build
- allowing twig 2.x as trellis itself doesn't use much of it anyways and
  project might want to upgrade from twig 1.x to 2.x

refs #30
graste added a commit that referenced this issue Jan 30, 2018
@graste
adjust mockery minimum version again for phpunit
4e4972e 
and php 5.6 build success. Maybe I read the sources correct this time.
refs #30

reordered the composer-flags env variable string to better see what is
being used as dependencies in the travisci UI. refs #30
graste added a commit that referenced this issue Jan 30, 2018
@graste
add nightly build and remove 7.2 lowest-deps build
fb1d4a2 
as phpunit is throwing fatals with lowest deps on php 7.2 but mockery
somehow needs an older phpunit and finding the sweet spot is not worth it
imho. refs #30
graste added a commit that referenced this issue Jan 30, 2018
@graste
coveralls report should be sent, refs #30
30557e6
@graste
Copy link
Member Author

graste commented Jan 30, 2018

From tag 0.2.1 on trellis should work on php 7.2 w/o (known) problems.

@graste graste closed this as completed Jan 30, 2018
@graste graste mentioned this issue Jan 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@graste graste

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@graste @Pictor13