-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from nose to tox/pytest #153
Open
dotysan
wants to merge
7
commits into
honeybadger-io:master
Choose a base branch
from
dotysan:tox-pytest
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- after pip installing latest git rev
- mostly beause I don't understand mock and how to debug it - TODO: these tests need to be fixed before PR merge
- setup.py replaced with setup.cfg and pyproject.toml - add requirements.txt - entire test matrix defined in tox.ini
This was referenced Jun 7, 2023
Closes #144. |
Closes #133. |
Closes #112. |
Hey @dotysan, thank you for this work!
I have a couple of questions:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a proof of concept...and an exercise in my learning how to use these tools.
Most notably, 2 Django and 5 Celery tests are still failing. But I temporarily disabled them just to prove it works.
A nice byproduct is that CI runs much quicker--and uses fewer minutes from GitHub Actions!
Thoughts?