Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from nose to tox/pytest #153

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

dotysan
Copy link
Contributor

@dotysan dotysan commented Jun 7, 2023

This is just a proof of concept...and an exercise in my learning how to use these tools.

Most notably, 2 Django and 5 Celery tests are still failing. But I temporarily disabled them just to prove it works.

A nice byproduct is that CI runs much quicker--and uses fewer minutes from GitHub Actions!

Thoughts?

 - after pip installing latest git rev
 - mostly beause I don't understand mock and how to debug it
 - TODO: these tests need to be fixed before PR merge
 - setup.py replaced with setup.cfg and pyproject.toml
 - add requirements.txt
 - entire test matrix defined in tox.ini
@dotysan
Copy link
Contributor Author

dotysan commented Jun 9, 2023

Closes #144.

@dotysan
Copy link
Contributor Author

dotysan commented Jun 9, 2023

Closes #133.

@dotysan
Copy link
Contributor Author

dotysan commented Jun 10, 2023

Closes #112.

@subzero10
Copy link
Member

Hey @dotysan, thank you for this work!

A nice byproduct is that CI runs much quicker--and uses fewer minutes from GitHub Actions!
🙌 🐎

I have a couple of questions:

  1. Are you working on making the failing tests pass (Django and Celery)? We need those passing in order to merge.
  2. Excuse my beginner question as I don't code Python often: Would this PR help us towards integrating with PDM or Poetry? Ideally, I would like us to use one of those tools for dependency management, testing and/or publishing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants