Minor fixes for "Fairy Floss" theme in 1.1.1 #1351
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrrnld
changed the title
rrrnld
changed the title
|
Heya, just wanted to check in if anything is unclear about this or if there's a way I can improve the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My instance was updated to 1.1.1 recently, and I noticed the background color does not fill the whole card for links without big preview images on top when using the fairy-floss theme:
Similarly, there's some background code missing to the right when the link content (title / preview) don't stretch the card content to fill the link horizontally:
This diff should fix that. There's some remaining styling for
.status-card.compact, but I don't know where that's used.The second commit fixes some issues with the dropdown that appears when clicking the "…" button on the bottom left of a post:
Before
After
My apologies if these changes should be made upstream somewhere, but I didn't find another repo for the theme.