Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package cleaning errors since golang 1.20 #357

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

joshperry
Copy link
Contributor

I guess adding packages to the go clean command always actually cleaned the whole cache, so adding this parameter was made into an error.

cref: golang/go#53725

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.62%. Comparing base (cb40038) to head (911fcf8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #357   +/-   ##
=======================================
  Coverage   83.62%   83.62%           
=======================================
  Files          14       14           
  Lines        1527     1527           
=======================================
  Hits         1277     1277           
  Misses        184      184           
  Partials       66       66           
Flag Coverage Δ
unittests 83.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HeavyWombat HeavyWombat merged commit c509496 into homeport:main Apr 3, 2024
6 checks passed
@HeavyWombat
Copy link
Member

Thanks for catching it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants