devicelist.cgi extended by device_id #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jens-maus
requested changes
Oct 25, 2023
There was a problem hiding this comment.
Thanks for this PR. However, as the other functions (mastervalue.cgi, mastervaluechange.cgi, state.cgi) provide the functionality to specify a list of device ids I would like to see the same functionality being implemented in devicelist.cgi. So please compare your implementation to these other functions and then adapt this PR accordingly.
The procedure for filtering devices has been changed to allow multiple IDs to be specified.
jens-maus
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves ticket #71